6208 Commits

Author SHA1 Message Date
Mitchell Hashimoto
1a7cde9e3e font/coretext: can read font tables 2024-05-27 20:23:10 -07:00
Mitchell Hashimoto
83dbcaad7a Merge pull request #1774 from il-k/elvish-integration-auto
feat(shell-integration): add automatic integration for Elvish
2024-05-27 16:19:26 -07:00
Mitchell Hashimoto
66a9b1b99f rename env var 2024-05-27 16:18:51 -07:00
Mitchell Hashimoto
982e4c9570 prettier 2024-05-27 16:16:43 -07:00
ilk
2863d2c148 refactor(shell-integration): refactor to make cases alphabetical
also fix: build errors
also fix: name mismatch (GHOSTTY_FISH_XDG_DIR -> GHOSTTY_INTEGRATION_DIR)
also refactor elvish file to evade unobvious returns
2024-05-27 16:15:13 -07:00
ilk
7377ca8917 refactor(shell-integration): refactor to make cases alphabetical
also refactors elvish file to evade unobvious returns
and tries to fix some build errors
2024-05-27 16:15:12 -07:00
ilk
1fa830cc73 feat(shell-integration): add automatic integration for Elvish
Fish automatic integration taken as an example.
Just like fish, Elvish checks `XDG_DATA_DIRS` for its modules.
Thus, Fish integration in zig is reused, and integration in
Elvish now removes `GHOSTTY_FISH_XDG_DIR` environment variable
on launch.
2024-05-27 16:15:01 -07:00
Mitchell Hashimoto
1032cdb68f Merge pull request #1772 from il-k/elvish-integration
feat(shell-integration): add integration for Elvish
2024-05-27 16:11:23 -07:00
Mitchell Hashimoto
17e7ff1de3 shell-integration: add README about Elvish 2024-05-27 16:11:08 -07:00
Mitchell Hashimoto
ded7c0abac Merge pull request #1760 from jcollie/notification-suppression
Rate limit desktop notifications
2024-05-26 20:50:19 -07:00
Mitchell Hashimoto
98b05ffd09 core: nitpick some var names 2024-05-26 20:49:00 -07:00
Mitchell Hashimoto
6ea739f08c Merge pull request #1799 from mitchellh/mixed-font
font: treated fonts with mixed color/non-color glyphs as text
2024-05-26 15:24:54 -07:00
Mitchell Hashimoto
9f4d4d3c61 font: treated fonts with mixed color/non-color glyphs as text
Related to #1768 but doesn't fix it properly.

This is a temporary hack to avoid some issues with fonts that have mixed
color/non-color glyphs. If there are mixed presentations and the font
does not have emoji codepoints, then we assume it is text. This fixes
the typical scenarios.

This is not a long term solution. A proper long term solution is to
detect this scenario and on a per-glyph basis handle colorization (or
the lack thereof) correctly. It looks like to do this we'll have to
parse some font tables which is considerably more work so I wanted to do
this first.
2024-05-26 10:17:20 -07:00
Mitchell Hashimoto
6a8db0526a Merge pull request #1797 from PeterCardenas/font-nitpick
make strikethrough calculation more clear
2024-05-26 12:28:30 -04:00
Mitchell Hashimoto
e427312282 modify var name 2024-05-26 09:28:16 -07:00
Mitchell Hashimoto
8e849df493 Merge pull request #1798 from Jan200101/PR/rel-path
build: prevent breakage with relative paths
2024-05-26 12:06:33 -04:00
Jan200101
11a9dd9dad build: prevent breakage with relative paths
`root()` returns `@src().file` which isn't guaranteed to be an absolute path
2024-05-26 17:46:26 +02:00
Peter Cardenas
e56acef775 🧹 make strikethrough calculation slightly clearer
followup to https://github.com/mitchellh/ghostty/pull/1796
the sources of the strikethrough calculation are made more explicit
here: the ascent and the subtraction of the leading
2024-05-26 01:44:26 -07:00
Mitchell Hashimoto
c84c63877c Merge pull request #1796 from mitchellh/strike
font/coretext: adjust strikethrough position for fonts with leading
2024-05-25 18:23:30 -04:00
Mitchell Hashimoto
bc99082242 font/coretext: adjust strikethrough position for fonts with leading
Fixes #1795

This only affected CoreText. When testing with Freetype the
strikethroughs looked correct for fonts with and without leading
metrics.

This commit adjusts our strikethrough position for fonts that have a
leading metric set to better center it. Previously, we centered the
position _including_ the leading value. The leading value is blank, so
we must center it excluding that value.
2024-05-25 15:20:16 -07:00
Mitchell Hashimoto
7df3f75db0 Merge pull request #1793 from Jan200101/PR/bold-is-bright
terminal: support using the bright palette for bold text
2024-05-25 17:20:03 -04:00
Mitchell Hashimoto
41afb62903 very minor nitpicks 2024-05-25 14:19:23 -07:00
Mitchell Hashimoto
0fdbf80381 nix: update hash 2024-05-25 14:12:56 -07:00
Mitchell Hashimoto
147238a7b9 update libxev
For #1794
2024-05-25 14:10:43 -07:00
Jan200101
94a7166028 terminal: support using the bright palette for bold text 2024-05-25 16:58:19 +02:00
Mitchell Hashimoto
3537820e75 Merge pull request #1788 from mitchellh/dependabot/github_actions/namespacelabs/nscloud-cache-action-1.1.5
build(deps): bump namespacelabs/nscloud-cache-action from 1.1.4 to 1.1.5
2024-05-24 07:43:25 -04:00
dependabot[bot]
678a42bb78 build(deps): bump namespacelabs/nscloud-cache-action from 1.1.4 to 1.1.5
Bumps [namespacelabs/nscloud-cache-action](https://github.com/namespacelabs/nscloud-cache-action) from 1.1.4 to 1.1.5.
- [Release notes](https://github.com/namespacelabs/nscloud-cache-action/releases)
- [Commits](https://github.com/namespacelabs/nscloud-cache-action/compare/v1.1.4...v1.1.5)

---
updated-dependencies:
- dependency-name: namespacelabs/nscloud-cache-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-24 00:51:52 +00:00
Mitchell Hashimoto
51b6bf46bf update README
Fixes #1773
2024-05-22 16:15:18 -04:00
Mitchell Hashimoto
4da59c21de Merge pull request #1785 from mattrobenolt/shell-plist
macos: Declare Ghostty as a Shell
2024-05-22 15:46:58 -04:00
Mitchell Hashimoto
063a20e085 Merge pull request #1786 from mitchellh/kittyimg
renderer: kitty image with y offset should stretch image
2024-05-22 15:44:53 -04:00
Mitchell Hashimoto
06bcbe868f renderer: kitty image with y offset should stretch image
Fixes #1784

This was just a misunderstanding of the "spec." When both a y offset
into the image is specified and a height, the image should be stretched.
I mistakingly thought that the image should be offset (even with this
misunderstanding there was a data corruption bug).

This resolves the issue and output matches Kitty.
2024-05-22 15:40:31 -04:00
Matt Robenolt
9b233b2d47 macos: Declare Ghostty as a Shell
tbh I'm not exactly sure what this does, but Kitty/Hyper/iTerm2 all
declare this.

https://github.com/kovidgoyal/kitty/blob/master/setup.py#L1419-L1422
https://gitlab.com/gnachman/iterm2/-/blob/master/plists/release-iTerm2.plist#L120-127
https://github.com/vercel/hyper/blob/master/electron-builder.json#L72-L79

I'm trying to get Ghostty to work correctly with OrbStack: https://github.com/orbstack/orbstack/issues/1012

And this stood out as the biggest difference.
2024-05-21 11:00:03 -07:00
Mitchell Hashimoto
9ad598facf Merge pull request #1783 from mitchellh/dependabot/github_actions/cachix/cachix-action-15
build(deps): bump cachix/cachix-action from 14 to 15
2024-05-21 07:08:07 -04:00
Mitchell Hashimoto
3eedb88acc Merge pull request #1782 from tt/avoid-coloring-when-using-native-tabs
Avoid coloring when using native tabs
2024-05-21 07:07:47 -04:00
Troels Thomsen
f79674097f Avoid coloring when using native tabs 2024-05-21 08:58:51 +02:00
Mitchell Hashimoto
47874742a1 Extract guard statement 2024-05-21 08:58:10 +02:00
Troels Thomsen
242858b963 Color after setting window theme and tab mode 2024-05-21 08:05:55 +02:00
dependabot[bot]
d2323990ee ---
updated-dependencies:
- dependency-name: cachix/cachix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-21 00:26:05 +00:00
Mitchell Hashimoto
57e33319a3 Merge pull request #1781 from tt/recognize-system-theme
Recognize system theme
2024-05-20 19:12:17 -04:00
Mitchell Hashimoto
c700d69b8e Merge pull request #1780 from gpanders/open-error-log
os: log stderr from open command
2024-05-20 19:11:54 -04:00
Mitchell Hashimoto
1e60f7186c os: some stylistic changes, comments for stderr logging 2024-05-20 19:11:30 -04:00
Troels Thomsen
6366d562ca Recognize system theme 2024-05-19 23:01:09 +02:00
Gregory Anders
e710a59a43 os: log stderr from open command 2024-05-19 09:00:53 -05:00
Mitchell Hashimoto
f72c2ac615 Merge pull request #1777 from mitchellh/lru-slow
font/shaper: periodically reset LRU in cache to avoid slowdown
2024-05-18 10:21:24 -04:00
Mitchell Hashimoto
d7c64f57b1 font/shaper: periodically reset LRU in cache to avoid slowdown
See: https://github.com/ziglang/zig/issues/17851

Users were noticing that frame render times got slower over time. I
believe (thanks to community for pointing it out) that this is the
culprit.

This works around this issue by clearing and reinitializing the LRU
after a certain number of evictions. When the Zig issue has a better
resolution (either rehash() as a workaround or a better hash
implementation overall) we can change this.
2024-05-18 10:06:41 -04:00
Mitchell Hashimoto
eee58b9ce6 macos: titlebar styling always applies to titlebar tabs 2024-05-17 20:38:51 -04:00
Jeffrey C. Ollie
7c893881c3 Address review comments
1. Switch to using Wyhash instead of a cryptographic hash.
2. Move global variables to App struct.
2024-05-17 17:13:43 -05:00
Mitchell Hashimoto
6860af0161 Merge pull request #1776 from mitchellh/reload-transparency
macos: only set bg color and titlebar color if opaque
2024-05-17 17:11:46 -04:00
Mitchell Hashimoto
bc29076f07 Merge pull request #1765 from jparise/bash-command-option
shell-integration: handle 'bash -c command'
2024-05-17 17:08:44 -04:00
Mitchell Hashimoto
92d551a3c1 macos: only set bg color and titlebar color if opaque
Fixes #1771

I'm not convinced this fix won't regress some other behavior, but in my
titlebar tab and native tab modes with and without transparency, this
has looked okay to me.
2024-05-17 17:05:21 -04:00