Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 08:46:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1797 from PeterCardenas/font-nitpick

Browse Source 
make strikethrough calculation more clear
This commit is contained in:
Mitchell Hashimoto
2024-05-26 12:28:30 -04:00
committed by GitHub
parent 8e849df493 e427312282
commit 6a8db0526a
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/font/face/coretext.zig
View File

@ -514,16 +514,15 @@ pub const Face = struct {
const cell_baseline = @ceil(layout_metrics.height - layout_metrics.ascent);
const underline_thickness = @ceil(@as(f32, @floatCast(ct_font.getUnderlineThickness())));
const strikethrough_position = strikethrough_position: {
// This is the height above baseline consumed by text. To get
// this, its cell height minus baseline. We must also take into
// account that our cell height splits the leading between two
// This is the height above baseline consumed by text. We must take
// into account that our cell height splits the leading between two
// rows so we subtract leading space (blank space).
const above = cell_height - cell_baseline - (layout_metrics.leading / 2);
const above_baseline = layout_metrics.ascent - (layout_metrics.leading / 2);
// We want to position the strikethrough at 65% of the height.
// This generally gives a nice visual appearance. The number 65%
// is somewhat arbitrary but is a common value across terminals.
const pos = above * 0.65;
const pos = above_baseline * 0.65;
break :strikethrough_position @ceil(pos);
};