4427 Commits

Author SHA1 Message Date
Mitchell Hashimoto
134327c1a3 termio/exec: reorder member since we like alloc on top 2023-12-30 21:46:27 -08:00
Mitchell Hashimoto
aef93a5420 config: make abnormal runtime threshold a u32 2023-12-30 21:45:16 -08:00
Jeffrey C. Ollie
4ef8d099a7 Make the abnormal runtime threshold configurable. 2023-12-30 22:52:47 -06:00
Jeffrey C. Ollie
792284fb69 Add exit code and runtime to abnormal exit error message. 2023-12-30 22:24:25 -06:00
Mitchell Hashimoto
8254ffb750 Merge pull request #1192 from mitchellh/abnormal-exit
Abnormal command exit detection
2023-12-30 19:46:08 -08:00
Mitchell Hashimoto
730343c600 termio/exec: pass code and runtime to error but don't show it yet 2023-12-30 19:37:38 -08:00
Mitchell Hashimoto
53dffc8e18 termio/exec: style the exec failure error better 2023-12-30 19:34:45 -08:00
Mitchell Hashimoto
f3aaa884c6 termio/exec: use message to writer thread so we can output failed cmd 2023-12-30 17:51:34 -08:00
Mitchell Hashimoto
aaded1f311 termio/exec: use arraylist to build up message for error 2023-12-30 15:52:26 -08:00
Mitchell Hashimoto
fc963064c6 termio/exec: abnormal exit can use exit code on linux 2023-12-30 15:43:50 -08:00
Mitchell Hashimoto
3ee842e1b7 config: remove command validation
Abnormal exit detection is more robust, and this validation always had
issues for example we didn't parse shell escapes and so on.
2023-12-30 15:36:13 -08:00
Mitchell Hashimoto
3fae05e2dc termio/exec: detect abnormally short runtime and show an error message 2023-12-30 15:35:35 -08:00
Mitchell Hashimoto
f43693152e Merge pull request #1191 from mitchellh/exec-failed
termio/exec: detect exec failure and show an error message
2023-12-30 15:35:09 -08:00
Mitchell Hashimoto
2ed75d47b5 termio/exec: detect exec failure and show an error message 2023-12-30 15:07:23 -08:00
Mitchell Hashimoto
8c5e8c504e config: skip command validation if it has a space
See comment
2023-12-30 14:46:05 -08:00
Mitchell Hashimoto
b7ef0d232f Merge pull request #1189 from mitchellh/macos-restore-blur
macos: wait for window to become visible to set blur
2023-12-29 21:59:05 -08:00
Mitchell Hashimoto
5e0e0b2bd4 macos: wait for window to become visible to set blur
Fixes #1181
2023-12-29 21:58:30 -08:00
Mitchell Hashimoto
85c386f45d termio: remove old warning log statement used for debugging 2023-12-29 21:25:07 -08:00
Mitchell Hashimoto
a159eafc18 Merge pull request #1180 from mitchellh/change-macos-launch
Modify the way the login shell is launched on macOS to reduce nesting
2023-12-29 15:50:18 -08:00
Mitchell Hashimoto
a69ec2127e termio/exec: use bash instead of zsh for shell launching 2023-12-29 15:41:11 -08:00
Mitchell Hashimoto
1652b9049a Merge pull request #1188 from rockorager/website-script-fix
website: fix ich and il scripts
2023-12-29 13:59:53 -08:00
Tim Culverhouse
165bbf4e56 website(il): fix test script
The IL V-3 test script has the cursor in the wrong position. Confirmed
with xterm. The cursor should end up in the first column.
2023-12-29 15:57:41 -06:00
Tim Culverhouse
b7ad30b067 website(ich): fix test script v1
The V-1 Test script was missing a printf statement. Add the missing
statement to make the expected output correct.

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
2023-12-29 15:57:41 -06:00
Mitchell Hashimoto
8feab70fa2 Merge pull request #1187 from rockorager/el-script-fix
website(el): clarify cursor position in test script
2023-12-29 13:23:36 -08:00
Tim Culverhouse
27be196fb4 website(el): clarify cursor position in test script
The test script for `el` shows the cursor being on the right side of
`X`, however in xterm and ghostty the cursor is _on_ the `X`. Delete the
cursor position and add a comment on where the cursor should be.
2023-12-29 15:19:20 -06:00
Mitchell Hashimoto
6763e9ef37 Merge pull request #1186 from rockorager/website-cub-fix
website: fix `cub` test script
2023-12-29 12:54:07 -08:00
Tim Culverhouse
23cd1d95e9 website: fix cub test script
The `CUB` V2 test script has a trailing echo which pushes the cursor
down one line, making the expected output incorrect. Remove the `echo`
command so the cursor position is as shown.
2023-12-29 14:52:53 -06:00
Mitchell Hashimoto
0006ca1d58 Merge pull request #1185 from mitchellh/cub-rw
terminal: cub with reverse wrap consumes pending wrap state as one
2023-12-29 12:49:36 -08:00
Mitchell Hashimoto
3e9a4ea234 terminal: cub with reverse wrap consumes pending wrap state as one
Related to #1184

See the updated website page and associated test.
2023-12-29 12:45:57 -08:00
Mitchell Hashimoto
884814eb03 Merge pull request #1184 from mitchellh/cub
terminal: cursor back should not reduce by one with pending wrap
2023-12-29 12:37:26 -08:00
Mitchell Hashimoto
fdd519f73b terminal: cursor back should not reduce by one with pending wrap
Fixes #1183

I'm not sure why the original logic was there. When I translated the
original test cases to shell and ran them in xterm, they did NOT match
what Ghostty expected. This updates the tests to match xterm and removes
this case. We can add back in more tests if/when we figure out under
what scenario this original logic was correct (if it ever was).
2023-12-29 12:34:33 -08:00
Mitchell Hashimoto
7815aeaa86 readme: misordered headers 2023-12-29 11:47:03 -08:00
Mitchell Hashimoto
5af5dbffaf update tester README to note friend invites, MIT, etc. 2023-12-29 11:46:21 -08:00
Mitchell Hashimoto
677cb05326 Merge pull request #1182 from mitchellh/command-path
config: validate that `command` can be found on the path
2023-12-29 11:41:19 -08:00
Mitchell Hashimoto
4ec2f50c1d config: validate that command can be found on the path 2023-12-29 11:22:34 -08:00
Matthew Winter
992888d4bd Ensure the cwd is not changed, whilst remaining a logon shell 2023-12-30 05:40:07 +11:00
Matthew Winter
9989436beb Ensure the shell environment passes the Login Shell test 2023-12-30 04:32:13 +11:00
Mitchell Hashimoto
b50ce6bb6a Merge pull request #1176 from tristan957/libadwaita
Use adw_application_new() instead of adw_init()
2023-12-29 09:11:21 -08:00
Mitchell Hashimoto
e43919cb9e apprt/gtk: stylistic changes to adwaita init 2023-12-29 09:10:49 -08:00
Matthew Winter
5e3e76bcae Modify the way the login shell is launched on macOS to reduce nesting 2023-12-30 03:51:16 +11:00
Mitchell Hashimoto
6532ff73a8 macos: verify inspector is not nil before sending it to draw 2023-12-29 07:53:20 -08:00
Mitchell Hashimoto
5cef3ced18 Merge pull request #1179 from mitchellh/keypad-maybe
input: only send keypad events for keypad application mode
2023-12-28 20:02:15 -08:00
Tristan Partin
41aa9ac2ff Use adw_application_new() instead of adw_init()
This will enable further libadwaita improvements in the future, but will
have no effect today.
2023-12-28 21:50:56 -06:00
Mitchell Hashimoto
c3fd37f687 Merge pull request #1178 from mitchellh/macos-restore
macos: invalid restorable state when surface is closed
2023-12-28 19:44:16 -08:00
Mitchell Hashimoto
40e882ff48 macos: invalid restorable state when surface is closed
Fixes #1177
2023-12-28 19:39:47 -08:00
Mitchell Hashimoto
f71c597037 Merge pull request #1174 from byildiz/main
Reorder menu items (File, Edit, View ...) like most of the other apps
2023-12-28 13:31:55 -08:00
Burak Yildiz
f3c6066be3 Reorder menu items (File, Edit, View ...) like most of the other apps 2023-12-28 21:43:24 +01:00
Mitchell Hashimoto
3b7dc97ad4 Merge pull request #1173 from mitchellh/release-entitlements
ci: explicitly sign our release entitlements on build
2023-12-28 10:38:22 -08:00
Mitchell Hashimoto
64e3cbf28c ci: explicitly sign our release entitlements on build
Fixes #1169
2023-12-28 10:37:45 -08:00
Mitchell Hashimoto
7fcd4233cd config: not that cursor-style with shell integration overwrites 2023-12-28 09:17:42 -08:00