Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 07:46:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

config: skip command validation if it has a space

Browse Source 
See comment
This commit is contained in:
Mitchell Hashimoto
2023-12-30 14:46:05 -08:00
parent b7ef0d232f
commit 8c5e8c504e
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/config/Config.zig
View File

@ -1707,7 +1707,17 @@ pub fn finalize(self: *Config) !void {
}
}
if (self.command) |command| {
if (self.command) |command| command: {
// If the command has a space in it, we skip the check below because
// its probably a multi-argument command. These types of commands
// can contain full shell escapes and other characters and we don't
// want to reimplement that all here. The point of the check below
// is MOSTLY to find people who do `command = myshell` where "myshell"
// is installed by something like Homebrew and therefore isn't available
// to a login shell. We will do more robust checks in the future by
// simply checking if the command exited with an error.
if (std.mem.indexOf(u8, command, " ") != null) break :command;
// If the path is not absolute then we want to expand it. We use our
// current path because our current path is what will be available
// to our termio launcher.