Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-08-02 14:57:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: hide windows without calling orderOut API

Browse Source
This commit is contained in:
Alexandre Antonio Juca
2025-01-09 23:14:00 +01:00
committed by Mitchell Hashimoto
parent 4dd9fe5cfd
commit 3a5aecc216
1 changed files with 6 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
macos/Sources/App/macOS/AppDelegate.swift
View File

@ -706,34 +706,13 @@ class AppDelegate: NSObject,
/// Toggles visibility of all Ghosty Terminal windows. When hidden, activates Ghostty as the frontmost application /// Toggles visibility of all Ghosty Terminal windows. When hidden, activates Ghostty as the frontmost application
@IBAction func toggleVisibility(_ sender: Any) { @IBAction func toggleVisibility(_ sender: Any) {
if let mainWindow = terminalManager.mainWindow { if isVisible {
guard let parent = mainWindow.controller.window else { NSApp.windows.forEach { window in
Self.logger.debug("could not get parent window") window.alphaValue = 0.0
return
} }
} else {
guard let controller = parent.windowController as? TerminalController, NSApp.windows.forEach { window in
let primaryWindow = controller.window else { window.alphaValue = 1.0
Self.logger.debug("Could not retrieve primary window")
return
}
// Fetch all terminal windows controlled by BaseTerminalController
for terminalWindow in NSApp.windows.filter({ $0.windowController is BaseTerminalController }) {
if isVisible {
terminalWindow.orderOut(nil)
} else {
primaryWindow.makeKeyAndOrderFront(nil)
primaryWindow.addTabbedWindow(terminalWindow, ordered: .above)
}
}
// If our parent tab group already has this window, macOS added it and
// we need to remove it so we can set the correct order in the next line.
// If we don't do this, macOS gets really confused and the tabbedWindows
// state becomes incorrect.
if let tg = parent.tabGroup, tg.windows.firstIndex(of: parent) != nil {
tg.removeWindow(parent)
} }
} }