fix: ensure terminal tabs are reconstructed in main window after toggling visibility

This commit is contained in:
Alexandre Antonio Juca
2025-01-07 22:54:02 +01:00
committed by Mitchell Hashimoto
parent d3de3448cc
commit 4dd9fe5cfd
2 changed files with 31 additions and 9 deletions

View File

@ -706,20 +706,42 @@ class AppDelegate: NSObject,
/// Toggles visibility of all Ghosty Terminal windows. When hidden, activates Ghostty as the frontmost application
@IBAction func toggleVisibility(_ sender: Any) {
// We only care about terminal windows.
for window in NSApp.windows.filter({ $0.windowController is BaseTerminalController }) {
if isVisible {
window.orderOut(nil)
} else {
window.makeKeyAndOrderFront(nil)
if let mainWindow = terminalManager.mainWindow {
guard let parent = mainWindow.controller.window else {
Self.logger.debug("could not get parent window")
return
}
guard let controller = parent.windowController as? TerminalController,
let primaryWindow = controller.window else {
Self.logger.debug("Could not retrieve primary window")
return
}
// Fetch all terminal windows controlled by BaseTerminalController
for terminalWindow in NSApp.windows.filter({ $0.windowController is BaseTerminalController }) {
if isVisible {
terminalWindow.orderOut(nil)
} else {
primaryWindow.makeKeyAndOrderFront(nil)
primaryWindow.addTabbedWindow(terminalWindow, ordered: .above)
}
}
// If our parent tab group already has this window, macOS added it and
// we need to remove it so we can set the correct order in the next line.
// If we don't do this, macOS gets really confused and the tabbedWindows
// state becomes incorrect.
if let tg = parent.tabGroup, tg.windows.firstIndex(of: parent) != nil {
tg.removeWindow(parent)
}
}
// After bringing them all to front we make sure our app is active too.
if !isVisible {
NSApp.activate(ignoringOtherApps: true)
}
isVisible.toggle()
}

View File

@ -26,7 +26,7 @@ class TerminalManager {
/// Returns the main window of the managed window stack. If there is no window
/// then an arbitrary window will be chosen.
private var mainWindow: Window? {
var mainWindow: Window? {
for window in windows {
if (window.controller.window?.isMainWindow ?? false) {
return window