Pete Schaffner
f086bff651
Make things work with really dark backgrounds
...
This fixes issue #1549
2024-04-02 22:28:34 +02:00
Pete Schaffner
bbe35ee02e
Revert luminance check from commit f7129880f5c4
...
This fixes the issues reporting wrong toolbar colors:
https://github.com/mitchellh/ghostty/pull/1550#issuecomment-2021538747
2024-03-28 10:51:00 +01:00
Pete Schaffner
cf6017e777
Revert "Revert "Merge pull request #1550 from peteschaffner/titlebar-unzoom-button""
...
This reverts commit 7f59d844c098f65158b4c5674f53371e0c4a4f1a.
2024-03-28 10:48:05 +01:00
Mitchell Hashimoto
9aadf59ab1
macos,libghostty: font size is a u8
2024-03-27 20:53:03 -07:00
Mitchell Hashimoto
45019fac7e
Merge pull request #1621 from mitchellh/font-size
...
font sizes are limited to u8 (max size = 255 points)
2024-03-27 20:48:36 -07:00
Mitchell Hashimoto
552c97eea4
font/freetype: avoid overflows with u8 font size
2024-03-27 20:45:55 -07:00
Mitchell Hashimoto
461b16ce34
font sizes are limited to u8 (max size = 255 points)
...
Fixes #1618
Font sizes in configuration were always a u8, but the keybinding and
internal state was a u16 so it allowed for an ever-growing font size. At
a certain point, there is an integer overflow which causes it to wrap
around. This is all silly, 255 should be large enough for anyone[1]
[1]: Ready to be super wrong about this
2024-03-27 20:36:59 -07:00
Mitchell Hashimoto
8cbda6c45f
Merge pull request #1620 from mitchellh/eraserows
...
Fix off-by-one errors in eraseRowBounded which could cause scroll region crashes
2024-03-27 20:33:15 -07:00
Mitchell Hashimoto
dce96847a9
terminal: test eraseRowBounded, fix off by ones
2024-03-27 20:23:45 -07:00
Mitchell Hashimoto
8d4f454e30
terminal: add integrity assertion that cursor pin matches x/y
2024-03-27 13:42:11 -07:00
Mitchell Hashimoto
43c4214ec1
Merge pull request #1619 from ianic/close-icon
...
gtk: use symbolic icon for tab close
2024-03-27 13:39:41 -07:00
Igor Anić
137359bcb5
gtk: use symbolic icon for tab close
...
On my system (xorg Ubuntu 24.04, Adwaita:dark theme) tab close icon was
red while in all other applications was more discrete. With adding
`-symbolic` to the icon name now looks like all other application.
2024-03-27 20:04:17 +01:00
Mitchell Hashimoto
2c2d441924
Merge pull request #1617 from mitchellh/grow-rows
...
terminal: when growing rows, need to set rows before grow()
2024-03-27 10:42:12 -07:00
Mitchell Hashimoto
050e6e4daa
terminal: when growing rows, need to set rows before grow()
...
grow() will not prune pages that are needed for the active but that
requires an accurate self.rows. We were setting this too late.
2024-03-27 10:38:31 -07:00
Mitchell Hashimoto
94e3e7b3d9
Merge pull request #1616 from mitchellh/macos-debug
...
macOS: upload signed/notarized debug builds
2024-03-27 09:59:27 -07:00
Mitchell Hashimoto
69d4e4f2a7
ci: put debug build in release
2024-03-27 09:58:17 -07:00
Mitchell Hashimoto
1be85e9d36
macos: show build in about window
2024-03-27 09:56:56 -07:00
Mitchell Hashimoto
b743b797f6
ci: add debug build to release-tip for macos
2024-03-27 09:46:20 -07:00
Mitchell Hashimoto
6aa2c2c509
Merge pull request #1615 from hovsater/cli-final-newline
...
Add final newline to CLI output
2024-03-27 07:36:16 -07:00
Kevin Hovsäter
e300d4766d
Add final newline to CLI output
2024-03-27 15:32:59 +01:00
Mitchell Hashimoto
caf2742b76
Merge pull request #1584 from mitchellh/paged-terminal
...
Low-memory terminal state implementation
2024-03-26 20:00:20 -07:00
Mitchell Hashimoto
c2053cba98
ci: release tip moves to namespace
2024-03-26 19:59:20 -07:00
Mitchell Hashimoto
e639ca1d1f
ci: try namespace again
2024-03-26 16:16:51 -07:00
Mitchell Hashimoto
a416d4236a
remove old terminal implementation
2024-03-26 16:14:25 -07:00
Mitchell Hashimoto
7f59d844c0
Revert "Merge pull request #1550 from peteschaffner/titlebar-unzoom-button"
...
This reverts commit 6b7a1ce1eb364936b58408bd67bbeaf0d3dc8579, reversing
changes made to b68e1c6a5d17b7e7b35902873a3241ee663f49a3.
2024-03-26 14:53:26 -07:00
Mitchell Hashimoto
ff30890465
Merge pull request #1612 from qwerasd205/scroll-regions
...
Fix scroll region performance regressions
2024-03-26 11:41:48 -07:00
Mitchell Hashimoto
0c4800b015
macos: usingColorSpace is only available with AppKit
2024-03-26 11:39:03 -07:00
Mitchell Hashimoto
ef4b3fed54
macos: remove some slight duplication
2024-03-26 11:14:43 -07:00
Mitchell Hashimoto
f7129880f5
macos: only set titlebar color with enough luminance to avoid #1549
2024-03-26 11:13:39 -07:00
Qwerasd
d17344b855
perf(terminal/page): @memset micro-optimization
2024-03-26 12:07:35 -06:00
Qwerasd
d72eb30a26
fastmem: fix doc comment
2024-03-26 12:07:35 -06:00
Qwerasd
492e147e26
terminal: clean up some code and comments
2024-03-26 12:07:35 -06:00
Qwerasd
2274b8a912
fix(terminal): don't reset x when indexing in scroll region
2024-03-26 12:07:35 -06:00
Qwerasd
aadf795d28
fix(terminal): correctly use slow path for left/right scroll margin
2024-03-26 12:07:35 -06:00
Qwerasd
23d32e248e
perf(terminal): fast-paths for scrolling regions
2024-03-26 12:07:35 -06:00
Qwerasd
d74ea89056
fastmem: rotateOnce
2024-03-26 12:07:35 -06:00
Qwerasd
ddd7f3e706
comments
2024-03-26 12:07:35 -06:00
Qwerasd
9df9c999a7
fix(terminal): clear erased rows
...
Clearing these rows is necessary to avoid memory corruption, but the
calls to `clearCells` in the first loop were redundant, since the rows
in question are included in the second loop as well.
2024-03-26 12:07:35 -06:00
Qwerasd
0a6ef3fda4
wip(terminal): Fast path for scroll regions
2024-03-26 12:07:35 -06:00
Mitchell Hashimoto
8f873dd488
Merge pull request #1593 from jcollie/log-build-info-2
...
log more information about the build
2024-03-26 09:47:49 -07:00
Mitchell Hashimoto
4e607e8901
only show optimization
2024-03-26 09:47:09 -07:00
Mitchell Hashimoto
6b7a1ce1eb
Merge pull request #1550 from peteschaffner/titlebar-unzoom-button
...
Add un-zoom button to titlebar and tabs
2024-03-26 09:41:53 -07:00
Mitchell Hashimoto
1ad973b274
Merge pull request #1609 from gpanders/kitty-alt-reset
...
terminal: reset alt screen kitty keyboard state on full reset
2024-03-26 06:46:48 -07:00
Gregory Anders
6c0609ddc8
terminal: reset alt screen kitty keyboard state on full reset
2024-03-26 08:33:21 -05:00
Mitchell Hashimoto
b68e1c6a5d
Merge pull request #1555 from BvngeeCord/gtk-tabs-location
...
add 'gtk-tabs-location'
2024-03-25 21:37:50 -07:00
Mitchell Hashimoto
f00242deaf
Merge pull request #1594 from aca/aca
...
apprt/gtk: commit buffer before "preeditchanged" resets
2024-03-25 21:36:44 -07:00
Mitchell Hashimoto
20870944fd
Merge pull request #1610 from gpanders/macos-kitty-associated-text
...
input: fix associated text on macOS
2024-03-25 20:25:01 -07:00
Mitchell Hashimoto
7f1af89abb
terminal: turn unreachable into todo
2024-03-25 20:11:21 -07:00
Mitchell Hashimoto
fcc0ea0c7c
terminal: explicit error set for page clone
2024-03-25 20:10:03 -07:00
Mitchell Hashimoto
ad5d7b6c5a
terminal: insert/deleteLines with L/R region across pages
2024-03-25 20:07:19 -07:00