Qwerasd
ed207514e9
typo
2025-05-15 11:59:17 -06:00
Qwerasd
709b0214a0
fix(renderer): Don't force images to grid/cell sizes
...
This problem was introduced by f091a69 (PR #6675 ).
I've gone ahead and overhauled the placement positioning logic as well;
it was doing a lot of expensive calls before, I've significantly reduced
that.
Clipping partially off-screen images is now handled entirely by the
renderer, rather than while preparing the placement, and as such the
grid position passed to the image shader is now signed.
2025-05-15 11:41:12 -06:00
Bryan Lee
2f814b37e8
Add unit tests for kitty image aspect ratio calculation
2025-03-12 22:44:17 +08:00
Bryan Lee
f091a69790
Fix aspect ratio when rendering images with kitty protocol
2025-03-12 15:06:06 +08:00
Jeffrey C. Ollie
f4f36a9a98
kitty: delete stray log line
2025-02-24 11:05:37 -06:00
Jeffrey C. Ollie
995959dce4
kitty images: add delete by range operations
...
Fixes #5937
Implement [deleting Kitty image ranges](https://sw.kovidgoyal.net/kitty/graphics-protocol/#deleting-images ).
2025-02-23 12:57:24 -06:00
Qwerasd
2f31e1b7fa
fix(kittygfx): don't respond to T commands with no i or I
...
If a transmit and display command does not specify an ID or a number,
then it should not be responded to. We currently automatically assign
IDs in this situation, which isn't ideal since collisions can happen
which shouldn't, but this at least fixes the glaring observable issue
where transmit-and-display commands yield unexpected OK responses.
2024-12-10 14:30:59 -05:00
Mitchell Hashimoto
1ee7da174b
flake: update to Nix 24.11
2024-12-05 12:15:48 -08:00
Mitchell Hashimoto
a1276b3cc3
terminal/kitty: delete all images ignores virtual placements
2024-07-29 19:37:47 -07:00
Mitchell Hashimoto
7d9e50353b
terminal/kitty: add virtual placeholders placements
2024-07-25 21:32:44 -07:00
Mitchell Hashimoto
a5c382633f
terminal/kitty: placements support location enum (only pin for now)
2024-07-25 21:32:43 -07:00
Mitchell Hashimoto
3fc08aa660
terminal/kitty: intersect cell deletion is 1-based
2024-07-05 19:08:33 -07:00
Mitchell Hashimoto
44c95cbf7d
terminal/kitty: delete by column/row is one-indexed
2024-07-05 18:59:21 -07:00
Mitchell Hashimoto
f4eea71859
terminal/kitty: image dimensions off by one fix
...
We weren't counting the original x/y as width 1.
2024-07-05 18:58:56 -07:00
Mitchell Hashimoto
3f16234f72
terminal: Coordinate uses CellCountInt
2024-04-26 20:52:08 -07:00
Mitchell Hashimoto
d7ee705a7a
terminal/kitty: calculate cell height more efficiently
2024-03-22 20:28:01 -07:00
Mitchell Hashimoto
49e8acbcd2
core: configurable scrollback limit
2024-03-22 20:27:59 -07:00
Mitchell Hashimoto
9c2a5bccc1
terminal: page size should be accounted every creation
2024-03-22 20:27:52 -07:00
Mitchell Hashimoto
25d84d697a
termio/exec: get compiler errors gone
2024-03-22 20:27:44 -07:00
Mitchell Hashimoto
9b4ab0e209
zig build test with renamed terminal package
2024-03-22 20:27:44 -07:00
Mitchell Hashimoto
793b657ca8
kitty-gfx: deletion should mark image state dirty to force redraw
...
Fixes #1537
2024-02-18 19:45:18 -08:00
Mitchell Hashimoto
238361698b
kitty graphics: use internal ID for placements with ID 0
...
Fixes #1356 correctly.
This was previously fixed by #1360 which just assigned a random
placement ID. I asked the Kitty maintainer about this and this is not
the correct logic and the spec has been updated.
When a placement ID of zero is sent, we allow multiple placements but
use an internal, non-addressable placement ID. The issue with my
previous approach was someone with knowledge of internals (or luck)
could technically address the placement. This isn't allowed.
2024-01-24 22:17:13 -08:00
Mitchell Hashimoto
ad23a7a2c9
terminal/kitty-gfx: erase all should preserve storage limit size
2023-09-17 09:27:01 -07:00
Mitchell Hashimoto
46ba3189f6
config: image-storage-limit to set maximum image memory per terminal
2023-08-23 16:58:16 -07:00
Mitchell Hashimoto
83e396044b
terminal/kitty-gfx: add per-screen storage limit
2023-08-23 14:14:31 -07:00
Mitchell Hashimoto
135250018e
terminal/kitty-gfx: get rid of selection
2023-08-23 11:41:49 -07:00
Mitchell Hashimoto
81498fe9be
terminal/kitty-gfx: delete newest
2023-08-23 11:35:14 -07:00
Mitchell Hashimoto
73976824a1
terminal/kitty-gfx: delete by column, row, z
2023-08-23 11:12:51 -07:00
Mitchell Hashimoto
6f7a9c4523
terminal/kitty-gfx: we need to use rect, not sel
2023-08-23 11:07:48 -07:00
Mitchell Hashimoto
98f1b55ea4
terminal/kitty-gfx: delete intersection
2023-08-23 11:00:13 -07:00
Mitchell Hashimoto
9ab25ef350
terminal/kitty-gfx: delete intersecting cursor
2023-08-23 10:53:38 -07:00
Mitchell Hashimoto
6244cc38cc
terminal/kitty-gfx: delete by id
2023-08-23 10:38:40 -07:00
Mitchell Hashimoto
4b38fb96db
terminal/kitty-gfx: honor "z" setting
2023-08-23 09:55:13 -07:00
Mitchell Hashimoto
7ff76ca00d
terminal/kitty-gfx: respect display c/r params
2023-08-22 14:43:50 -07:00
Mitchell Hashimoto
3bbfee676b
terminal/kitty-gfx: process source rectangle display params
2023-08-22 14:33:41 -07:00
Mitchell Hashimoto
84c72bbe46
renderer/metal: honor cell offset graphics command
2023-08-22 13:28:40 -07:00
Mitchell Hashimoto
e6155b7f19
terminal/kitty-gfx: add placement function get selection
2023-08-22 13:15:00 -07:00
Mitchell Hashimoto
da4ead8f60
renderer/metal: deallocate unused image textures
2023-08-21 22:11:58 -07:00
Mitchell Hashimoto
11bf2680b7
terminal/kitty-gfx: make some args const
2023-08-21 16:07:41 -07:00
Mitchell Hashimoto
660faf3ac3
terminal: clear screen, alt screen, etc. clear all kitty graphics
2023-08-21 15:34:46 -07:00
Mitchell Hashimoto
fe79bd5cc9
terminal/kitty-gfx: centralize all image loading on LoadingImage
2023-08-21 11:40:03 -07:00
Mitchell Hashimoto
bbcb2f96c8
terminal/kitty-gfx: huge progress on chunked transfers, lots of issues
2023-08-20 22:03:21 -07:00
Mitchell Hashimoto
e84f82bd97
terminal/kitty-gfx: assign an internal image id
2023-08-20 22:03:21 -07:00
Mitchell Hashimoto
b3a3ca1182
terminal/kitty-gfx: placement now works properly
2023-08-20 22:03:21 -07:00
Mitchell Hashimoto
7bec2820a7
terminal/kitty-gfx: start working on placements
2023-08-20 22:03:21 -07:00
Mitchell Hashimoto
80c7f09a36
terminal/kitty-gfx: start terminal state, can load and add images
2023-08-20 22:03:21 -07:00
