Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 15:56:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

code review

Browse Source
This commit is contained in:
Damien Mehala
2025-01-11 22:19:42 +01:00
parent 95fc1d64c8
commit fc99c99b74
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/terminal/osc.zig
View File

@ -380,7 +380,6 @@ pub const Parser = struct {
conemu_progress_state, conemu_progress_state,
conemu_progress_prevalue, conemu_progress_prevalue,
conemu_progress_value, conemu_progress_value,
conemu_wait,
}; };
/// This must be called to clean up any allocated memory. /// This must be called to clean up any allocated memory.
@ -816,7 +815,7 @@ pub const Parser = struct {
self.state = .conemu_progress_prestate; self.state = .conemu_progress_prestate;
}, },
'5' => { '5' => {
self.state = .conemu_wait; self.state = .swallow;
self.command = .{ .wait_input = {} }; self.command = .{ .wait_input = {} };
self.complete = true; self.complete = true;
}, },
@ -952,11 +951,6 @@ pub const Parser = struct {
}, },
}, },
.conemu_wait => {
self.state = .invalid;
self.complete = false;
},
.query_fg_color => switch (c) { .query_fg_color => switch (c) {
'?' => { '?' => {
self.command = .{ .report_color = .{ .kind = .foreground } }; self.command = .{ .report_color = .{ .kind = .foreground } };
@ -2122,16 +2116,16 @@ test "OSC: OSC9 conemu wait input" {
try testing.expect(cmd == .wait_input); try testing.expect(cmd == .wait_input);
} }
test "OSC: OSC9 conemu wait invalid input" { test "OSC: OSC9 conemu wait ignores trailing characters" {
const testing = std.testing; const testing = std.testing;
var p: Parser = .{}; var p: Parser = .{};
const input = "9;5;"; const input = "9;5;foo";
for (input) |ch| p.next(ch); for (input) |ch| p.next(ch);
const cmd = p.end('\x1b'); const cmd = p.end('\x1b').?;
try testing.expect(cmd == null); try testing.expect(cmd == .wait_input);
} }
test "OSC: empty param" { test "OSC: empty param" {