From fc99c99b74f72776ac39ba8c3d9028e38f4db07d Mon Sep 17 00:00:00 2001
From: Damien Mehala <damien.mehala@gmail.com>
Date: Sat, 11 Jan 2025 22:19:42 +0100
Subject: [PATCH] code review

---
 src/terminal/osc.zig | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/src/terminal/osc.zig b/src/terminal/osc.zig
index 01f017731..10ba5b5e7 100644
--- a/src/terminal/osc.zig
+++ b/src/terminal/osc.zig
@@ -380,7 +380,6 @@ pub const Parser = struct {
         conemu_progress_state,
         conemu_progress_prevalue,
         conemu_progress_value,
-        conemu_wait,
     };
 
     /// This must be called to clean up any allocated memory.
@@ -816,7 +815,7 @@ pub const Parser = struct {
                     self.state = .conemu_progress_prestate;
                 },
                 '5' => {
-                    self.state = .conemu_wait;
+                    self.state = .swallow;
                     self.command = .{ .wait_input = {} };
                     self.complete = true;
                 },
@@ -952,11 +951,6 @@ pub const Parser = struct {
                 },
             },
 
-            .conemu_wait => {
-                self.state = .invalid;
-                self.complete = false;
-            },
-
             .query_fg_color => switch (c) {
                 '?' => {
                     self.command = .{ .report_color = .{ .kind = .foreground } };
@@ -2122,16 +2116,16 @@ test "OSC: OSC9 conemu wait input" {
     try testing.expect(cmd == .wait_input);
 }
 
-test "OSC: OSC9 conemu wait invalid input" {
+test "OSC: OSC9 conemu wait ignores trailing characters" {
     const testing = std.testing;
 
     var p: Parser = .{};
 
-    const input = "9;5;";
+    const input = "9;5;foo";
     for (input) |ch| p.next(ch);
 
-    const cmd = p.end('\x1b');
-    try testing.expect(cmd == null);
+    const cmd = p.end('\x1b').?;
+    try testing.expect(cmd == .wait_input);
 }
 
 test "OSC: empty param" {