Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 08:46:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

window (mac): recalculate sizes on new tab

Browse Source 
When a new tab is added, the tab bar may appear which causes our size
grid size calculation to become invalidated. We weren't updating this
previously, which had the effect of mouse selection being in the wrong
place. There were likely other effects...

Fixes https://github.com/mitchellh/ghostty/issues/69
This commit is contained in:
Mitchell Hashimoto
2023-01-26 08:54:09 -08:00
parent 414201abf9
commit f2b59353ab
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/Window.zig
View File

@ -492,7 +492,7 @@ pub fn shouldClose(self: Window) bool {
}
/// Add a window to the tab group of this window.
pub fn addWindow(self: Window, other: *Window) void {
pub fn addWindow(self: *Window, other: *Window) void {
assert(builtin.target.isDarwin());
// This has a hard dependency on GLFW currently. If we want to support
@ -507,6 +507,19 @@ pub fn addWindow(self: Window, other: *Window) void {
objc.Object.fromId(other_win),
NSWindowOrderingMode.above,
});
// Adding a new tab can cause the tab bar to appear which changes
// our viewport size. We need to call the size callback in order to
// update values. For example, we need this to set the proper mouse selection
// point in the grid.
const size = self.window.getSize() catch |err| {
log.err("error querying window size for size callback on new tab err={}", .{err});
return;
};
self.sizeCallback(size) catch |err| {
log.err("error in size callback from new tab err={}", .{err});
return;
};
}
/// Called from the app thread to handle mailbox messages to our specific