Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-21 19:26:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

input: legacy encoding pc style keys should ignore directional modifiers

Browse Source
This commit is contained in:
Mitchell Hashimoto
2023-10-12 12:28:26 -07:00
parent f402ca140c
commit d97e5b9dab
1 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/input/KeyEncoder.zig
View File

@ -319,7 +319,11 @@ fn pcStyleFunctionKey(
keypad_key_application: bool,
modify_other_keys: bool, // True if state 2
) ?[]const u8 {
const mods_int = mods.int();
// We only want binding-sensitive mods because lock keys
// and directional modifiers (left/right) don't matter for
// pc-style function keys.
const mods_int = mods.binding().int();
for (function_keys.keys.get(keyval)) |entry| {
switch (entry.cursor) {
.any => {},
@ -1328,6 +1332,38 @@ test "legacy: f1" {
}
}
test "legacy: left_shift+tab" {
var buf: [128]u8 = undefined;
var enc: KeyEncoder = .{
.event = .{
.key = .tab,
.mods = .{
.shift = true,
.sides = .{ .shift = .left },
},
},
};
const actual = try enc.legacy(&buf);
try testing.expectEqualStrings("\x1b[Z", actual);
}
test "legacy: right_shift+tab" {
var buf: [128]u8 = undefined;
var enc: KeyEncoder = .{
.event = .{
.key = .tab,
.mods = .{
.shift = true,
.sides = .{ .shift = .right },
},
},
};
const actual = try enc.legacy(&buf);
try testing.expectEqualStrings("\x1b[Z", actual);
}
test "ctrlseq: normal ctrl c" {
const seq = ctrlSeq(.c, .{ .ctrl = true });
try testing.expectEqual(@as(u8, 0x03), seq.?);