macos: break reference cycle to window to allow window to free memory

Fixes #366

The comment in the Swift code explains what was happening here:

> I don't know if this is the right place, but because of WindowAccessor in our
> SwiftUI hierarchy, we have a reference cycle between view and window and windows
> are never freed. When the window is closed, the window controller is deinitialized,
> so we can use this opportunity detach the view from the window and break the cycle.

An alternate solution would be to make our reference back to the window
"weak" but we appear to not be able to do that with SwiftUI property
wrappers such as `@State` and `@Binding` and so on.
This commit is contained in:
Mitchell Hashimoto
2023-09-01 09:12:03 -07:00
parent a6007cab7a
commit d945640401

View File

@ -11,4 +11,14 @@ class PrimaryWindowController: NSWindowController {
guard let manager = self.windowManager else { return }
manager.triggerNewTab(for: window)
}
deinit {
// I don't know if this is the right place, but because of WindowAccessor in our
// SwiftUI hierarchy, we have a reference cycle between view and window and windows
// are never freed. When the window is closed, the window controller is deinitialized,
// so we can use this opportunity detach the view from the window and break the cycle.
if let window = self.window {
window.contentView = nil
}
}
}