Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 15:56:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

font: fix sign of usWinDescent interpretation (#2960)

Browse Source 
comment explains

In the future we should probably find or craft example fonts that have
weird metrics in their tables and make unit tests for them.
This commit is contained in:
Mitchell Hashimoto
2024-12-13 10:50:37 -08:00
committed by GitHub
parent b2a9af7359 4573890f22
commit a73cb2b258
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/font/face/coretext.zig
View File

@ -647,7 +647,9 @@ pub const Face = struct {
const win_descent: f64 = @floatFromInt(os2.usWinDescent);
break :vertical_metrics .{
win_ascent * px_per_unit,
win_descent * px_per_unit,
// usWinDescent is *positive* -> down unlike sTypoDescender
// and hhea.Descender, so we flip its sign to fix this.
-win_descent * px_per_unit,
0.0,
};
};

4
src/font/face/freetype.zig
View File

@ -689,7 +689,9 @@ pub const Face = struct {
const win_descent: f64 = @floatFromInt(os2.usWinDescent);
break :vertical_metrics .{
win_ascent * px_per_unit,
win_descent * px_per_unit,
// usWinDescent is *positive* -> down unlike sTypoDescender
// and hhea.Descender, so we flip its sign to fix this.
-win_descent * px_per_unit,
0.0,
};
};