Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 15:56:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

config: for now, make goto_tab NOT performable on macOS (#7788)

Browse Source 
Fixes #7786
Fixes regression from #7683

This is a band-aid fix. The issue is that performable keybinds don't
show up in the reverse mapping that GUI toolkits use to find their key
equivalents. The full explanation of why is already in Binding.zig.

For macOS, we have a way to validate menu items before they're triggered
so we ideally do want a way to get reverse mappings even with
performable keybinds. But I think this wants to be optional and that's
all a bigger change. For now, this is a simple fix that will work.
This commit is contained in:
Mitchell Hashimoto
2025-07-03 13:51:54 -07:00
committed by GitHub
parent 3e9cfacb7d e1be836283
commit 8e14d26275
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/config/Config.zig
View File

@ -5455,7 +5455,14 @@ pub const Keybinds = struct {
.mods = mods,
},
.{ .goto_tab = (i - start) + 1 },
.{ .performable = true },
.{
// On macOS we keep this not performable so that the
// keyboard shortcuts in tabs work. In the future the
// correct fix is to fix the reverse mapping lookup
// to allow us to lookup performable keybinds
// conditionally.
.performable = !builtin.target.os.tag.isDarwin(),
},
);
}
try self.set.putFlags(
@ -5465,7 +5472,10 @@ pub const Keybinds = struct {
.mods = mods,
},
.{ .last_tab = {} },
.{ .performable = true },
.{
// See comment above with the numeric goto_tab
.performable = !builtin.target.os.tag.isDarwin(),
},
);
}