Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-08-02 14:57:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

reorganize logic to make better semantic sense

Browse Source 
This should be functionally identical, it just makes more sense written
this way. When releasing the style we simultaneously clear the ID back
to default, and after that point it's guaranteed to be default until
changed again so we don't need to set it before returning if the new
style is default or before adding the style to the new page.
This commit is contained in:
Qwerasd
2024-12-24 22:55:05 -05:00
parent 8fdd69b795
commit 813f6d4d58
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/terminal/Screen.zig
View File

@ -1774,18 +1774,11 @@ pub fn manualStyleUpdate(self: *Screen) !void {
// Release our previous style if it was not default.
if (self.cursor.style_id != style.default_id) {
page.styles.release(page.memory, self.cursor.style_id);
}
// If our new style is the default, just reset to that
if (self.cursor.style.default()) {
self.cursor.style_id = style.default_id;
return;
}
// Clear the cursor style ID to prevent weird things from happening
// if the page capacity has to be adjusted which would end up calling
// manualStyleUpdate again.
self.cursor.style_id = style.default_id;
// If our new style is the default, then we're done.
if (self.cursor.style.default()) return;
// After setting the style, we need to update our style map.
// Note that we COULD lazily do this in print. We should look into