Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-21 11:16:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

terminal: on clone, only mark rows dirty that were previously dirty

Browse Source
This commit is contained in:
Mitchell Hashimoto
2024-04-28 14:14:55 -07:00
parent d47f14f86a
commit 7e52f94278
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/terminal/PageList.zig
View File

@ -4861,7 +4861,9 @@ test "PageList clone full dirty" {
// Should still be dirty
try testing.expect(s2.isDirty(.{ .active = .{ .x = 0, .y = 0 } }));
try testing.expect(!s2.isDirty(.{ .active = .{ .x = 0, .y = 1 } }));
try testing.expect(s2.isDirty(.{ .active = .{ .x = 0, .y = 12 } }));
try testing.expect(!s2.isDirty(.{ .active = .{ .x = 0, .y = 14 } }));
try testing.expect(s2.isDirty(.{ .active = .{ .x = 0, .y = 23 } }));
}

14
src/terminal/page.zig
View File

@ -500,16 +500,12 @@ pub const Page = struct {
const other_rows = other.rows.ptr(other.memory)[y_start..y_end];
const rows = self.rows.ptr(self.memory)[0 .. y_end - y_start];
for (rows, other_rows) |*dst_row, *src_row| {
try self.cloneRowFrom(other, dst_row, src_row);
}
// Set our dirty range for all the rows we copied
const other_dirty_set = other.dirtyBitSet();
var dirty_set = self.dirtyBitSet();
dirty_set.setRangeValue(.{
.start = 0,
.end = y_end - y_start,
}, true);
for (rows, 0.., other_rows, y_start..) |*dst_row, dst_y, *src_row, src_y| {
try self.cloneRowFrom(other, dst_row, src_row);
if (other_dirty_set.isSet(src_y)) dirty_set.set(dst_y);
}
// We should remain consistent
self.assertIntegrity();