Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-08-02 14:57:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

apprt/gtk-ng: hook up bell ringing (#8065)

Browse Source 
For now, this just emits a signal that an embedding widget will react to
to do something like flashing the window.

I think we should implement the audio bell in the actual surface view
but I don't currently have audio drivers hooked up in my Linux VM and
I'm away from my desktop PC. :)

cc @jcollie if you're interested, pretty tightly scoped.
This commit is contained in:
Mitchell Hashimoto
2025-07-25 09:29:16 -07:00
committed by GitHub
parent 6d6b911fad b36b7031a1
commit 787960e56d
2 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/apprt/gtk-ng/class/application.zig
View File

@ -485,6 +485,8 @@ pub const Application = extern struct {
.render => Action.render(self, target),
.ring_bell => Action.ringBell(target),
.set_title => Action.setTitle(target, value),
.show_child_exited => return Action.showChildExited(target, value),
@ -515,7 +517,6 @@ pub const Application = extern struct {
.toggle_window_decorations,
.prompt_title,
.toggle_quick_terminal,
.ring_bell,
.toggle_command_palette,
.open_url,
.close_all_windows,
@ -1138,6 +1139,13 @@ const Action = struct {
}
}
pub fn ringBell(target: apprt.Target) void {
switch (target) {
.app => {},
.surface => |v| v.rt_surface.surface.ringBell(),
}
}
pub fn setTitle(
target: apprt.Target,
value: apprt.action.SetTitle,

28
src/apprt/gtk-ng/class/surface.zig
View File

@ -213,6 +213,21 @@ pub const Surface = extern struct {
);
};
/// The bell is rung.
///
/// The surface view handles the audio bell feature but none of the
/// others so it is up to the embedding widget to react to this.
pub const bell = struct {
pub const name = "bell";
pub const connect = impl.connect;
const impl = gobject.ext.defineSignal(
name,
Self,
&.{},
void,
);
};
/// Emitted whenever the clipboard has been written.
pub const @"clipboard-write" = struct {
pub const name = "clipboard-write";
@ -343,6 +358,18 @@ pub const Surface = extern struct {
priv.gl_area.queueRender();
}
/// Ring the bell.
pub fn ringBell(self: *Self) void {
// TODO: Audio feature
signals.bell.impl.emit(
self,
null,
.{},
null,
);
}
/// Set the current progress report state.
pub fn setProgressReport(
self: *Self,
@ -1979,6 +2006,7 @@ pub const Surface = extern struct {
// Signals
signals.@"close-request".impl.register(.{});
signals.bell.impl.register(.{});
signals.@"clipboard-read".impl.register(.{});
signals.@"clipboard-write".impl.register(.{});