Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-15 16:26:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

terminal: OSC parses 4 with empty string param without crashing

Browse Source
This commit is contained in:
Mitchell Hashimoto
2024-02-12 19:30:04 -08:00
parent 02e0230131
commit 739fc746bf
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/terminal/osc.zig
View File

@ -445,8 +445,14 @@ pub const Parser = struct {
.color_palette_index => switch (c) {
'0'...'9' => {},
';' => {
if (std.fmt.parseUnsigned(u8, self.buf[self.buf_start .. self.buf_idx - 1], 10)) |num| {
';' => blk: {
const str = self.buf[self.buf_start .. self.buf_idx - 1];
if (str.len == 0) {
self.state = .invalid;
break :blk;
}
if (std.fmt.parseUnsigned(u8, str, 10)) |num| {
self.state = .color_palette_index_end;
self.temp_state = .{ .num = num };
} else |err| switch (err) {
@ -1254,3 +1260,15 @@ test "OSC: show desktop notification with title" {
try testing.expectEqualStrings(cmd.show_desktop_notification.title, "Title");
try testing.expectEqualStrings(cmd.show_desktop_notification.body, "Body");
}
test "OSC: empty param" {
const testing = std.testing;
var p: Parser = .{};
const input = "4;;";
for (input) |ch| p.next(ch);
const cmd = p.end('\x1b');
try testing.expect(cmd == null);
}