Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-17 17:26:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1511 from truemedian/refuzzed

Browse Source 
Realpath with nulls and malformed OSC 4 causing panics
This commit is contained in:
Mitchell Hashimoto
2024-02-12 19:32:15 -08:00
committed by GitHub
parent 739fc746bf 9193cfa6d2
commit 6a3b676779
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/terminal/kitty/graphics_image.zig
View File

@ -75,6 +75,16 @@ pub const LoadingImage = struct {
log.warn("failed to decode base64 data: {}", .{err}); log.warn("failed to decode base64 data: {}", .{err});
return error.InvalidData; return error.InvalidData;
}; };
if (comptime builtin.os != .windows) {
if (std.mem.indexOfScalar(u8, buf[0..size], 0) == null) {
// std.os.realpath *asserts* that the path does not have
// internal nulls instead of erroring.
log.warn("failed to get absolute path: BadPathName", .{});
return error.InvalidData;
}
}
var abs_buf: [std.fs.MAX_PATH_BYTES]u8 = undefined; var abs_buf: [std.fs.MAX_PATH_BYTES]u8 = undefined;
const path = std.os.realpath(buf[0..size], &abs_buf) catch |err| { const path = std.os.realpath(buf[0..size], &abs_buf) catch |err| {
log.warn("failed to get absolute path: {}", .{err}); log.warn("failed to get absolute path: {}", .{err});