Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 00:36:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

terminal: avoid underflow on resize, tests added

Browse Source
This commit is contained in:
Mitchell Hashimoto
2023-08-12 11:30:07 -07:00
parent 6fec9f8096
commit 63fa34ef6b
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/terminal/Screen.zig
View File

@ -2170,7 +2170,7 @@ pub fn resize(self: *Screen, rows: usize, cols: usize) !void {
// If the end of our copy is wide, we copy one less and
// set the wide spacer header now since we're not going
// to write over it anyways.
if (wrapped_cells[wrapped_i + proposed - 1].cell.attrs.wide) {
if (proposed > 0 and wrapped_cells[wrapped_i + proposed - 1].cell.attrs.wide) {
proposed -= 1;
new_row.getCellPtr(x + proposed).* = .{
.char = ' ',
@ -4842,6 +4842,18 @@ test "Screen: resize more cols no reflow" {
}
}
// https://github.com/mitchellh/ghostty/issues/272#issuecomment-1676038963
test "Screen: resize more cols perfect split" {
const testing = std.testing;
const alloc = testing.allocator;
var s = try init(alloc, 3, 5, 0);
defer s.deinit();
const str = "1ABCD2EFGH3IJKL";
try s.testWriteString(str);
try s.resize(3, 10);
}
test "Screen: resize more cols trailing background colors" {
const testing = std.testing;
const alloc = testing.allocator;