Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-08-02 14:57:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

apprt/gtk-ng: fix scrolling on surface (#8080)

Browse Source 
We forgot to specify the scroll controller's `flags` property.
This commit is contained in:
Mitchell Hashimoto
2025-07-26 12:17:09 -07:00
committed by GitHub
parent fd1db0c8e6 b5c1f52ddb
commit 18831374ca
2 changed files with 22 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
src/apprt/gtk-ng/class/surface.zig
View File

@ -1647,32 +1647,30 @@ pub const Surface = extern struct {
self: *Self,
) callconv(.c) c_int {
const priv = self.private();
if (priv.core_surface) |surface| {
// Multiply precision scrolls by 10 to get a better response from
// touchpad scrolling
const multiplier: f64 = if (priv.precision_scroll) 10.0 else 1.0;
const scroll_mods: input.ScrollMods = .{
.precision = priv.precision_scroll,
};
const surface = priv.core_surface orelse return 0;
const scaled = self.scaledCoordinates(x, y);
surface.scrollCallback(
// We invert because we apply natural scrolling to the values.
// This behavior has existed for years without Linux users complaining
// but I suspect we'll have to make this configurable in the future
// or read a system setting.
scaled.x * -1 * multiplier,
scaled.y * -1 * multiplier,
scroll_mods,
) catch |err| {
log.warn("error in scroll callback err={}", .{err});
return 0;
};
// Multiply precision scrolls by 10 to get a better response from
// touchpad scrolling
const multiplier: f64 = if (priv.precision_scroll) 10.0 else 1.0;
const scroll_mods: input.ScrollMods = .{
.precision = priv.precision_scroll,
};
return 1;
}
const scaled = self.scaledCoordinates(x, y);
surface.scrollCallback(
// We invert because we apply natural scrolling to the values.
// This behavior has existed for years without Linux users complaining
// but I suspect we'll have to make this configurable in the future
// or read a system setting.
scaled.x * -1 * multiplier,
scaled.y * -1 * multiplier,
scroll_mods,
) catch |err| {
log.warn("error in scroll callback err={}", .{err});
return 0;
};
return 0;
return 1;
}
fn imPreeditStart(

1
src/apprt/gtk-ng/ui/1.2/surface.blp
View File

@ -103,6 +103,7 @@ template $GhosttySurface: Adw.Bin {
scroll => $scroll();
scroll-begin => $scroll_begin();
scroll-end => $scroll_end();
flags: both_axes;
}
GestureClick {