mirror of
https://github.com/go-gitea/gitea.git
synced 2025-06-29 02:38:46 +03:00
6d0b24064a
Extract from #34531 ## Move Commit status state to a standalone package Move the state from `structs` to `commitstatus` package. It also introduce `CommitStatusStates` so that the combine function could be used from UI and API logic. ## Combined commit status Changed This PR will follow Github's combined commit status. Before this PR, every commit status could be a combined one. According to https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#get-the-combined-status-for-a-specific-reference > Additionally, a combined state is returned. The state is one of: > failure if any of the contexts report as error or failure > pending if there are no statuses or a context is pending > success if the latest status for all contexts is success This PR will follow that rule and remove the `NoBetterThan` logic. This also fixes the inconsistent between UI and API. In the API convert package, it has implemented this which is different from the UI. It also fixed the missing `URL` and `CommitURL` in the API. ## `CalcCommitStatus` return nil if there is no commit statuses The behavior of `CalcCommitStatus` is changed. If the parameter commit statuses is empty, it will return nil. The reference places should check the returned value themselves.
84 lines
2.8 KiB
Go
84 lines
2.8 KiB
Go
// Copyright 2024 The Gitea Authors.
|
|
// All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package pull
|
|
|
|
import (
|
|
"testing"
|
|
|
|
git_model "code.gitea.io/gitea/models/git"
|
|
"code.gitea.io/gitea/modules/commitstatus"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestMergeRequiredContextsCommitStatus(t *testing.T) {
|
|
cases := []struct {
|
|
commitStatuses []*git_model.CommitStatus
|
|
requiredContexts []string
|
|
expected commitstatus.CommitStatusState
|
|
}{
|
|
{
|
|
commitStatuses: []*git_model.CommitStatus{},
|
|
requiredContexts: []string{},
|
|
expected: commitstatus.CommitStatusPending,
|
|
},
|
|
{
|
|
commitStatuses: []*git_model.CommitStatus{
|
|
{Context: "Build xxx", State: commitstatus.CommitStatusSkipped},
|
|
},
|
|
requiredContexts: []string{"Build*"},
|
|
expected: commitstatus.CommitStatusSuccess,
|
|
},
|
|
{
|
|
commitStatuses: []*git_model.CommitStatus{
|
|
{Context: "Build 1", State: commitstatus.CommitStatusSkipped},
|
|
{Context: "Build 2", State: commitstatus.CommitStatusSuccess},
|
|
{Context: "Build 3", State: commitstatus.CommitStatusSuccess},
|
|
},
|
|
requiredContexts: []string{"Build*"},
|
|
expected: commitstatus.CommitStatusSuccess,
|
|
},
|
|
{
|
|
commitStatuses: []*git_model.CommitStatus{
|
|
{Context: "Build 1", State: commitstatus.CommitStatusSuccess},
|
|
{Context: "Build 2", State: commitstatus.CommitStatusSuccess},
|
|
{Context: "Build 2t", State: commitstatus.CommitStatusPending},
|
|
},
|
|
requiredContexts: []string{"Build*", "Build 2t*"},
|
|
expected: commitstatus.CommitStatusPending,
|
|
},
|
|
{
|
|
commitStatuses: []*git_model.CommitStatus{
|
|
{Context: "Build 1", State: commitstatus.CommitStatusSuccess},
|
|
{Context: "Build 2", State: commitstatus.CommitStatusSuccess},
|
|
{Context: "Build 2t", State: commitstatus.CommitStatusFailure},
|
|
},
|
|
requiredContexts: []string{"Build*", "Build 2t*"},
|
|
expected: commitstatus.CommitStatusFailure,
|
|
},
|
|
{
|
|
commitStatuses: []*git_model.CommitStatus{
|
|
{Context: "Build 1", State: commitstatus.CommitStatusSuccess},
|
|
{Context: "Build 2", State: commitstatus.CommitStatusSuccess},
|
|
{Context: "Build 2t", State: commitstatus.CommitStatusSuccess},
|
|
},
|
|
requiredContexts: []string{"Build*", "Build 2t*", "Build 3*"},
|
|
expected: commitstatus.CommitStatusPending,
|
|
},
|
|
{
|
|
commitStatuses: []*git_model.CommitStatus{
|
|
{Context: "Build 1", State: commitstatus.CommitStatusSuccess},
|
|
{Context: "Build 2", State: commitstatus.CommitStatusSuccess},
|
|
{Context: "Build 2t", State: commitstatus.CommitStatusSuccess},
|
|
},
|
|
requiredContexts: []string{"Build*", "Build *", "Build 2t*", "Build 1*"},
|
|
expected: commitstatus.CommitStatusSuccess,
|
|
},
|
|
}
|
|
for i, c := range cases {
|
|
assert.Equal(t, c.expected, MergeRequiredContextsCommitStatus(c.commitStatuses, c.requiredContexts), "case %d", i)
|
|
}
|
|
}
|