mirror of
https://github.com/go-gitea/gitea.git
synced 2025-04-22 01:18:45 +03:00
a100ac3306
Fix #28144 To make the resources will be cleanup once failed. All repository operations now follow a consistent pattern: - 1. Create a database record for the repository with the status being_migrated. - 2. Register a deferred cleanup function to delete the repository and its related data if the operation fails. - 3. Perform the actual Git and database operations step by step. - 4. Upon successful completion, update the repository’s status to ready. The adopt operation is a special case — if it fails, the repository on disk should not be deleted.
126 lines
4.2 KiB
Go
126 lines
4.2 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repository
|
|
|
|
import (
|
|
"os"
|
|
"path"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/util"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCheckUnadoptedRepositories_Add(t *testing.T) {
|
|
start := 10
|
|
end := 20
|
|
unadopted := &unadoptedRepositories{
|
|
start: start,
|
|
end: end,
|
|
index: 0,
|
|
}
|
|
|
|
total := 30
|
|
for i := 0; i < total; i++ {
|
|
unadopted.add("something")
|
|
}
|
|
|
|
assert.Equal(t, total, unadopted.index)
|
|
assert.Len(t, unadopted.repositories, end-start)
|
|
}
|
|
|
|
func TestCheckUnadoptedRepositories(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
//
|
|
// Non existent user
|
|
//
|
|
unadopted := &unadoptedRepositories{start: 0, end: 100}
|
|
err := checkUnadoptedRepositories(db.DefaultContext, "notauser", []string{"repo"}, unadopted)
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, unadopted.repositories)
|
|
//
|
|
// Unadopted repository is returned
|
|
// Existing (adopted) repository is not returned
|
|
//
|
|
userName := "user2"
|
|
repoName := "repo2"
|
|
unadoptedRepoName := "unadopted"
|
|
unadopted = &unadoptedRepositories{start: 0, end: 100}
|
|
err = checkUnadoptedRepositories(db.DefaultContext, userName, []string{repoName, unadoptedRepoName}, unadopted)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []string{path.Join(userName, unadoptedRepoName)}, unadopted.repositories)
|
|
//
|
|
// Existing (adopted) repository is not returned
|
|
//
|
|
unadopted = &unadoptedRepositories{start: 0, end: 100}
|
|
err = checkUnadoptedRepositories(db.DefaultContext, userName, []string{repoName}, unadopted)
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, unadopted.repositories)
|
|
assert.Equal(t, 0, unadopted.index)
|
|
}
|
|
|
|
func TestListUnadoptedRepositories_ListOptions(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
username := "user2"
|
|
unadoptedList := []string{path.Join(username, "unadopted1"), path.Join(username, "unadopted2")}
|
|
for _, unadopted := range unadoptedList {
|
|
_ = os.Mkdir(filepath.Join(setting.RepoRootPath, unadopted+".git"), 0o755)
|
|
}
|
|
|
|
opts := db.ListOptions{Page: 1, PageSize: 1}
|
|
repoNames, count, err := ListUnadoptedRepositories(db.DefaultContext, "", &opts)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 2, count)
|
|
assert.Equal(t, unadoptedList[0], repoNames[0])
|
|
|
|
opts = db.ListOptions{Page: 2, PageSize: 1}
|
|
repoNames, count, err = ListUnadoptedRepositories(db.DefaultContext, "", &opts)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 2, count)
|
|
assert.Equal(t, unadoptedList[1], repoNames[0])
|
|
}
|
|
|
|
func TestAdoptRepository(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
|
|
// a successful adopt
|
|
destDir := filepath.Join(setting.RepoRootPath, user2.Name, "test-adopt.git")
|
|
assert.NoError(t, unittest.SyncDirs(filepath.Join(setting.RepoRootPath, user2.Name, "repo1.git"), destDir))
|
|
|
|
adoptedRepo, err := AdoptRepository(db.DefaultContext, user2, user2, CreateRepoOptions{Name: "test-adopt"})
|
|
assert.NoError(t, err)
|
|
repoTestAdopt := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{Name: "test-adopt"})
|
|
assert.Equal(t, "sha1", repoTestAdopt.ObjectFormatName)
|
|
|
|
// just delete the adopted repo's db records
|
|
err = deleteFailedAdoptRepository(adoptedRepo.ID)
|
|
assert.NoError(t, err)
|
|
|
|
unittest.AssertNotExistsBean(t, &repo_model.Repository{OwnerName: user2.Name, Name: "test-adopt"})
|
|
|
|
// a failed adopt because some mock data
|
|
// remove the hooks directory and create a file so that we cannot create the hooks successfully
|
|
_ = os.RemoveAll(filepath.Join(destDir, "hooks", "update.d"))
|
|
assert.NoError(t, os.WriteFile(filepath.Join(destDir, "hooks", "update.d"), []byte("tests"), os.ModePerm))
|
|
|
|
adoptedRepo, err = AdoptRepository(db.DefaultContext, user2, user2, CreateRepoOptions{Name: "test-adopt"})
|
|
assert.Error(t, err)
|
|
assert.Nil(t, adoptedRepo)
|
|
|
|
unittest.AssertNotExistsBean(t, &repo_model.Repository{OwnerName: user2.Name, Name: "test-adopt"})
|
|
|
|
exist, err := util.IsExist(repo_model.RepoPath(user2.Name, "test-adopt"))
|
|
assert.NoError(t, err)
|
|
assert.True(t, exist) // the repository should be still in the disk
|
|
}
|