mirror of
https://github.com/ghostty-org/ghostty.git
synced 2025-04-22 01:18:36 +03:00

Fixes #5328 The dock sits above the level of the quick terminal, and the quick terminal frame typical includes the dock. Hence, if the dock is visible and the quick terminal would conflict with it, then part of the terminal is obscured. This commit makes the dock autohide if the quick terminal would conflict with it. The autohide is disabled when the quick terminal is closed. We can't set our window level above the dock, as this would prevent things such as input methods from rendering properly in the quick terminal window. iTerm2 (the only other macOS terminal I know of that supports a dropdown mode) frames the terminal around the dock. I think this looks less aesthetically pleasing and I prefer autohiding the dock instead. We can introduce a setting to change this behavior if desired later. Additionally, this commit introduces a mechanism to safely set app-global presentation options from multiple sources without stepping on each other.
32 lines
1.2 KiB
Swift
32 lines
1.2 KiB
Swift
import Cocoa
|
|
|
|
extension NSApplication {
|
|
private static var presentationOptionCounts: [NSApplication.PresentationOptions.Element: UInt] = [:]
|
|
|
|
/// Add a presentation option to the application and main a reference count so that and equal
|
|
/// number of pops is required to disable it. This is useful so that multiple classes can affect global
|
|
/// app state without overriding others.
|
|
func acquirePresentationOption(_ option: NSApplication.PresentationOptions.Element) {
|
|
Self.presentationOptionCounts[option, default: 0] += 1
|
|
presentationOptions.insert(option)
|
|
}
|
|
|
|
/// See acquirePresentationOption
|
|
func releasePresentationOption(_ option: NSApplication.PresentationOptions.Element) {
|
|
guard let value = Self.presentationOptionCounts[option] else { return }
|
|
guard value > 0 else { return }
|
|
if (value == 1) {
|
|
presentationOptions.remove(option)
|
|
Self.presentationOptionCounts.removeValue(forKey: option)
|
|
} else {
|
|
Self.presentationOptionCounts[option] = value - 1
|
|
}
|
|
}
|
|
}
|
|
|
|
extension NSApplication.PresentationOptions.Element: @retroactive Hashable {
|
|
public func hash(into hasher: inout Hasher) {
|
|
hasher.combine(rawValue)
|
|
}
|
|
}
|