ghostty

mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-24 04:36:10 +03:00

History

Mitchell Hashimoto d65fbba39e config: do not load command from SHELL when launched from desktop

Fixes #139

From the issue:

Looking into this now, I think I figured out the broken logic. When launching
from open, the parent process of Ghostty is launchd which appears to set your
SHELL env var to your configured shell when logging in. That's why a restart
fixes it. However, I believe directory services (the macOS equivalent to
/etc/passwd) is updated in real time.

Ghostty does read directory services but at a lower priority than SHELL.
This logic makes sense for CLI-launched terminals but not desktop-launched.
From a CLI you want the terminal you're launching to probably inherit the shell
from the CLI you launched it from. (Note that using open explicitly forces a
launchd-style launch so it quacks as if it was double-clicked on the desktop).

In conclusion, I believe the correct logic is to invert the priority on SHELL
vs directory services when Ghostty detects it was launched from launchd. We
already have this detection logic in Ghostty because we use it for a number of
other things as well, so this should be easy to fix. I'll work on it later
today.

2024-01-06 12:31:01 -08:00

c_get.zig

config: make unfocused-split-fill default to bg

2023-12-13 19:06:25 -08:00

CAPI.zig

fix callback struct ordering, use internal_os.open

2023-12-18 08:00:40 -08:00

Config.zig

config: do not load command from SHELL when launched from desktop

2024-01-06 12:31:01 -08:00

edit.zig

config: create the config dir recursively for edit