Mitchell Hashimoto
5ff0841ee6
Merge pull request #2243 from gpanders/push-yvplumostzqp
...
config: interpret leading ? in config-file as an optional file
2024-09-17 13:04:52 -07:00
Mitchell Hashimoto
22cdb6cbc5
Merge pull request #2254 from qwerasd205/sequoia-title-fix
...
Sequoia titlebar tabs fix
2024-09-17 12:36:03 -07:00
Qwerasd
2852c771b1
macos: fix various titlebar tabs problems in macOS 15.0
...
- Toolbar overflow indicator showing
- Doubled title on single-tab windows
- Tabs not properly placed in bar on restore of saved window
2024-09-16 22:54:00 -06:00
Mitchell Hashimoto
0109cb5ba4
Merge pull request #2248 from ghostty-org/tagged-union
...
cli: config structure supports tagged unions
2024-09-16 16:01:04 -07:00
Mitchell Hashimoto
a389987ada
cli: config structure supports tagged unions
...
The syntax of tagged unions is `tag:value`. This matches the tagged
union parsing syntax for keybindings (i.e. `new_split:right`).
I'm adding this now on its own without a user-facing feature because
I can see some places we might use this and I want to separate this out.
There is already a PR open now that can utilize this (#2231 ).
2024-09-16 15:53:59 -07:00
Mitchell Hashimoto
605bbb8f97
Merge pull request #2251 from tristan957/toast
...
apprt/gtk: add notebook widget to the main box
2024-09-16 15:12:41 -07:00
Mitchell Hashimoto
fca7ceed03
apprt/gtk: fix non-libadw builds
2024-09-16 15:08:41 -07:00
Tristan Partin
2ad4dcdc01
apprt/gtk: remove redundant adwaita check
...
We already check if the toast overlay exists before sending a toast.
Signed-off-by: Tristan Partin <tristan@partin.io>
2024-09-16 15:42:38 -05:00
Tristan Partin
4f2c1d1b10
apprt/gtk: use adwaita toasts regardless of gtk-titlebar
...
Signed-off-by: Tristan Partin <tristan@partin.io>
2024-09-16 15:36:10 -05:00
Tristan Partin
46fb3d8c9f
apprt/gtk: add notebook widget to the main box
...
Mitchell dropped this as part of a cleanup in the PR which added
AdwToastOverlay.
Fixes: https://github.com/ghostty-org/ghostty/issues/2250
Link: https://github.com/ghostty-org/ghostty/pull/2235
Signed-off-by: Tristan Partin <tristan@partin.io>
2024-09-16 15:16:06 -05:00
Mitchell Hashimoto
dfe62cec85
Merge pull request #2235 from tristan957/toast
...
apprt/gtk: use toast UX from Adwaita if available
2024-09-16 10:22:09 -07:00
Mitchell Hashimoto
c48a1801f6
apprt/gtk: only setup the toast overlay if we have it enabled
2024-09-16 10:18:02 -07:00
Mitchell Hashimoto
2f0b48e8ad
apprt/gtk: tweaks
2024-09-16 10:12:16 -07:00
Tristan Partin
d0c6c4f367
apprt/gtk: use toast UX from Adwaita if available
...
Notify the user with in-app notifications if libadwaita is available.
Co-authored-by: Paul Berg <paul@ber.gp>
Signed-off-by: Tristan Partin <tristan@partin.io>
2024-09-16 11:57:58 -05:00
Mitchell Hashimoto
bc14ac3672
Merge pull request #2247 from Pangoraw/warning-new-position
...
gtk: prevent invalid call to adw_tab_view_get_selected_page
2024-09-16 09:35:07 -07:00
Paul Berg
89506e5933
gtk: prevent invalid call to adw_tab_view_get_page_position
...
Creating the first tab would call adw_tab_view_get_page_position with a null page.
2024-09-16 18:10:57 +02:00
Gregory Anders
21e40e9842
config: interpret leading ? in config-file as an optional file
...
For example, `config-file = ?config.foo` will not report an error if
`config.foo` does not exist.
2024-09-15 09:47:44 -05:00
Mitchell Hashimoto
4241eac890
Merge pull request #2245 from ghostty-org/push-uktsxxotkmuz
...
config: "-e" implies quit after last window closed
2024-09-13 21:06:36 -07:00
Mitchell Hashimoto
a9217bd9da
config: "-e" implies quit after last window closed
...
Fixes #2220
2024-09-13 20:57:54 -07:00
Mitchell Hashimoto
779b721618
Merge pull request #2163 from jcollie/gtk-desktop-notification-fix
...
GTK: Fix clicking on desktop notifications
2024-09-13 20:52:18 -07:00
Mitchell Hashimoto
841e12a1eb
config: make window-padding-color default to "background"
...
Unfortunately this is a failed experiment. The idea works in many
scenarios, but there are too many valid cases where it confuses people
or results in a very subjective experience. I'm going to revert this
back to "background" to act like other terminals, but the feature
remains available through config.
2024-09-13 20:51:15 -07:00
Mitchell Hashimoto
941adcdac8
apprt/gtk: rename the other underscore actions to match naming rules
2024-09-13 20:49:31 -07:00
Mitchell Hashimoto
9e73d865fb
apprt/gtk: small comments
2024-09-13 20:45:39 -07:00
Mitchell Hashimoto
35e11c09e0
pkg: add README and license
2024-09-13 19:55:11 -07:00
Jeffrey C. Ollie
5f759a19d1
GTK: Fix clicking on desktop notifications
...
Currently, clicking on a desktop notification will bring Ghostty
to the foreground, but it won't necessarily bring the right window
to the top and it won't switch tabs or change the focus on splits.
With this patch, clicking on a desktop notification will raise the
correct window, change to the correct tab, and focus on the correct
split that send the original desktop notification.
2024-09-13 13:37:38 -07:00
Mitchell Hashimoto
9548ae532d
Merge pull request #2228 from Pangoraw/window-theme
...
apprt/gtk: add option to color header bars with theme colors
2024-09-13 10:09:44 -07:00
Mitchell Hashimoto
ddb3700609
config: copy
2024-09-13 10:08:48 -07:00
Mitchell Hashimoto
d0e3ec5581
Merge pull request #2239 from Pangoraw/notebook-nobox
...
apprt/gtk: make Notebook.create not depend on parent box
2024-09-13 09:58:23 -07:00
Mitchell Hashimoto
4a539cf4c9
apprt/gtk: style tweaks
2024-09-13 09:51:51 -07:00
Paul Berg
1037265cd9
apprt/gtk: make Notebook.create not depend on parent box
2024-09-13 09:44:41 -07:00
Mitchell Hashimoto
30a2e50d96
Merge pull request #2242 from jcollie/gtk-split-separator
...
gtk: prevent split separator from becoming transparent
2024-09-13 09:36:13 -07:00
Jeffrey C. Ollie
12a791ddf2
gtk: prevent split separator from becoming transparent
2024-09-13 10:03:58 -05:00
Mitchell Hashimoto
d22e12f18f
Merge pull request #2241 from Pangoraw/adw_tab_page
...
apprt/gtk: remove adw_tab_page from tab
2024-09-13 06:48:52 -07:00
Paul Berg
b935c7d46c
apprt/gtk: remove adw_tab_page from tab
2024-09-13 15:32:17 +02:00
Mitchell Hashimoto
83927f18c3
Merge pull request #2240 from Pangoraw/notebook-position
...
apprt/gtk: respect window-new-tab-position again
2024-09-13 06:15:11 -07:00
Paul Berg
d7f6f9999f
config: remove note that window-new-tab-position is gtk only
2024-09-13 11:38:39 +02:00
Paul Berg
3dc4185d50
apprt/gtk: respect window-new-tab-position again
2024-09-13 11:37:23 +02:00
Paul
ac985937cd
apprt/gtk: add theme variant in window-theme
...
this colours the header bar with the config colour.
2024-09-13 10:06:42 +02:00
Mitchell Hashimoto
32b3dfed9d
Merge pull request #2237 from jcollie/adw-overview-zero-tabs
...
adw: allow creating new tabs in a tab overview with no open tabs
2024-09-12 21:01:02 -07:00
Jeffrey C. Ollie
80c1fd436f
adw: allow creating new tabs in a tab overview with no open tabs
...
Repro:
1) Start up Ghostty and create two windows.
2) On one window, open up the tab overview and close all of the tabs.
3) The window will not dissapear and should show that you have no open
tabs because the 2nd Ghostty window is keeping Ghostty from quitting.
4) Clicking on the "New Tab" button has no effect.
Fix is to allow creating a new tab even though there is no action surface.
2024-09-12 21:04:06 -05:00
Mitchell Hashimoto
ab50025da7
Merge pull request #2236 from ghostty-org/dependabot/github_actions/cachix/install-nix-action-V28
...
build(deps): bump cachix/install-nix-action from V27 to 28
2024-09-12 18:07:33 -07:00
dependabot[bot]
31207dbb6e
build(deps): bump cachix/install-nix-action from V27 to 28
...
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action ) from V27 to 28. This release includes the previously tagged commit.
- [Release notes](https://github.com/cachix/install-nix-action/releases )
- [Commits](https://github.com/cachix/install-nix-action/compare/V27...V28 )
---
updated-dependencies:
- dependency-name: cachix/install-nix-action
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-09-13 00:56:03 +00:00
Mitchell Hashimoto
415f5cfe1b
Merge pull request #2233 from tristan957/about
...
apprt/gtk: use AdwAboutDialog if available
2024-09-12 16:23:56 -07:00
Mitchell Hashimoto
66f055275d
Merge pull request #2232 from tristan957/tabview
...
apprt/gtk: Add support for AdwTabOverview
2024-09-12 16:19:20 -07:00
Mitchell Hashimoto
fced4370d3
apprt/gtk: some tweaks, avoid uninitialized memory access, use optionals
2024-09-12 16:14:48 -07:00
Tristan Partin
f35671417c
apprt/gtk: use AdwTabOverview
...
An additional way to manage tabs.
Signed-off-by: Tristan Partin <tristan@partin.io>
2024-09-12 15:59:07 -07:00
Mitchell Hashimoto
423d25ac93
Merge pull request #2229 from tristan957/headerbar
...
apprt/gtk: use AdwHeaderBar if available
2024-09-12 15:57:47 -07:00
Mitchell Hashimoto
3a60fd6550
apprt/gtk: use GtkWidget so there is a common ancestor
2024-09-12 15:54:07 -07:00
Tristan Partin
b7d26a3ac3
apprt/gtk: use AdwAboutDialog if available
...
Matches the libadwaita theme and UX.
Signed-off-by: Tristan Partin <tristan@partin.io>
2024-09-12 23:34:34 +01:00
Tristan Partin
a30fad7c59
apprt/gtk: use AdwHeaderBar if available
...
Signed-off-by: Tristan Partin <tristan@partin.io>
2024-09-12 20:29:50 +01:00