2895 Commits

Author SHA1 Message Date
Mitchell Hashimoto
008738df56 core: only prevent repeat mouse events for motion
Fixes #485
2023-09-18 09:15:26 -07:00
Mitchell Hashimoto
c0e097efba Merge pull request #483 from mitchellh/gtk-config-errors
gtk: configuration errors window
2023-09-18 08:59:34 -07:00
Mitchell Hashimoto
3d602017dd Merge pull request #484 from marler8997/fixWindowsFontconfigCrash
windows: fix fontconfig into libxml runtime crash from implicit func decl
2023-09-18 08:26:17 -07:00
Jonathan Marler
a0911c954e windows: fix fontconfig into libxml runtime crash from implicit func decl
Fixes the next issue on windows.  The fontconfig library is calling
the function xmlCreatePushParserCtxt from libxml2, however, the function
declaration was being omitted because fontconfig was not defining
the LIBXML_PUSH_ENABLED preprocessor symbol.  However, instead of a
compile error, C's support for implicit function declrations allows it
to happily call the function anyway, with the wrong ABI.  The main issue
was the return type being implicitly declared as "int" instead of a
pointer.  On my system this was causing the return pointer to be
truncated to 32 bits and then sign-extended which caused a segfault
once it was dereferenced.

I've gone ahead and added the -Werror=implicit-function-declaration
to fontconfig to avoid these issues in the future.  However, this
flag didn't compile on linux so I've left it as Windows only for now.

I also needed to add the LIBXML_STATIC define because not defining it
causes some functions on windows to be declared with
`__declspec(dllimport)` which results in linker errors since we are
actually statically linking libxml2.
2023-09-18 01:12:56 -06:00
Mitchell Hashimoto
6df01b87c1 apprt/gtk: if errors fixed, hide window 2023-09-17 22:34:34 -07:00
Mitchell Hashimoto
80e02c6c9f apprt/gtk: update config error contents on reload 2023-09-17 22:31:52 -07:00
Mitchell Hashimoto
92465f57ea apprt/gtk: grab focus of config window when reloading 2023-09-17 22:28:58 -07:00
Mitchell Hashimoto
f82fd56933 apprt/gtk: hook up buttons 2023-09-17 22:09:44 -07:00
Mitchell Hashimoto
40315afe72 apprt/gtk: extract config errors window into views 2023-09-17 22:03:43 -07:00
Mitchell Hashimoto
fe15e7d5fd apprt/gtk: add View to help with auto-layout views 2023-09-17 21:59:25 -07:00
Mitchell Hashimoto
bd3b5d5332 apprt/gtk: working on config errors window 2023-09-17 21:37:57 -07:00
Mitchell Hashimoto
dbd8add23e core: don't send release events for key bindings
Fixes #482
2023-09-17 14:31:15 -07:00
Mitchell Hashimoto
ef7e0f7fdb core: mouse reports should always send on release even if outside
Fixes #481
2023-09-17 14:22:40 -07:00
Mitchell Hashimoto
37cf0b2321 Merge pull request #443 from mitchellh/hide-decorations-macos
macos: allow to hide decorations
2023-09-17 12:07:13 -07:00
Mitchell Hashimoto
d911c49f44 macos: remove unnecessary call 2023-09-17 12:01:36 -07:00
SoraTenshi
833be445ba Spawn alert box on new tab if decorations disabled
Stray spaces

Fix check for windowDecoration
2023-09-17 11:58:11 -07:00
Mitchell Hashimoto
2b380ad37e macos: stylistic changes 2023-09-17 11:57:36 -07:00
Mitchell Hashimoto
48de8c0837 c: remove unused struct field 2023-09-17 11:57:01 -07:00
Will Pragnell
81efb2dfe5 macos: always use latest window decoration config from runtime 2023-09-17 11:57:01 -07:00
SoraTenshi
ddb9be0971 Remove custom CAPI function
and use the already existing get_config function
2023-09-17 11:57:01 -07:00
SoraTenshi
3cb21dd76e Store and restore style mask on fullscreen 2023-09-17 11:57:00 -07:00
SoraTenshi
4c1cf5efe3 fixup! macos: allow to hide decorations 2023-09-17 11:57:00 -07:00
SoraTenshi
ed8b5bc283 macos: allow to hide decorations 2023-09-17 11:57:00 -07:00
Mitchell Hashimoto
63379ee2eb Merge pull request #480 from mitchellh/mouse-fixes
Mouse Reporting Fixes
2023-09-17 11:55:37 -07:00
Mitchell Hashimoto
36c9d607b2 core: do not send repeat mouse events if cell didn't change 2023-09-17 11:49:25 -07:00
Mitchell Hashimoto
ab4acf0d00 core: send mouse motion events if motion tracking and button pressed 2023-09-17 11:45:53 -07:00
Mitchell Hashimoto
d6b827cce7 core: all SGR mouse report modes can tell button differences
Fixes #478
2023-09-17 10:24:51 -07:00
Mitchell Hashimoto
083e42f5d2 Merge pull request #477 from mitchellh/notcurses-input
notcurses-input bugs
2023-09-17 10:08:17 -07:00
Mitchell Hashimoto
dd85f6c41d core: do not emit mouse report events if position is outside surface 2023-09-17 09:56:26 -07:00
Mitchell Hashimoto
8694d29bd0 terminal: ignore CSI S with intermediates 2023-09-17 09:39:03 -07:00
Mitchell Hashimoto
ad23a7a2c9 terminal/kitty-gfx: erase all should preserve storage limit size 2023-09-17 09:27:01 -07:00
Mitchell Hashimoto
a851483d08 Merge pull request #474 from mitchellh/gtk-refactor
GTK refactor, ability to drag tab out to new window
2023-09-16 12:41:12 -07:00
Mitchell Hashimoto
84da10a9b3 apprt/gtk: don't use userdata for pages, can request on demand
This is important to keep it in sync if the gl area moves
2023-09-16 12:11:10 -07:00
Mitchell Hashimoto
cf84a5513f apprt/gtk: listen to page-removed to hide tab bar if only one 2023-09-16 11:48:33 -07:00
Mitchell Hashimoto
5dc0746a17 gtk: tabs are draggable to the desktop to extract a window 2023-09-16 11:30:22 -07:00
Mitchell Hashimoto
0cf2ed6a9f renderer/opengl: gl state init needs to set blending, realization 2023-09-16 11:26:07 -07:00
Mitchell Hashimoto
f7272d506e apprt/gtk: handle scenario where OpenGL area becomes unrealized 2023-09-16 09:38:28 -07:00
Mitchell Hashimoto
a19acf14d2 renderer/opengl: support reloading the Opengl state 2023-09-16 09:37:29 -07:00
Mitchell Hashimoto
58100f0a00 renderer/opengl: OpenGL state may be nil to disable rendering 2023-09-16 09:08:35 -07:00
Mitchell Hashimoto
d2fa79effb apprt/gtk: shuffle some lines around in Window 2023-09-16 08:32:32 -07:00
Mitchell Hashimoto
35c956fd05 apprt/gtk: Window css styling is no longer used 2023-09-16 08:29:15 -07:00
Mitchell Hashimoto
d5036e78f4 apprt/gtk: refactor into separate files 2023-09-16 08:28:49 -07:00
Mitchell Hashimoto
cbbafc70e2 gtk: set Name for new-window action 2023-09-15 22:10:06 -07:00
Mitchell Hashimoto
e0691cfcfa Merge pull request #461 from mitchellh/goonz/windows-path-and-tmpdir
Windows: implement tmpDir and expandPath
2023-09-15 17:15:46 -07:00
Mitchell Hashimoto
23054dc393 main: only check for CLI actions on non-lib builds 2023-09-15 17:14:12 -07:00
Mitchell Hashimoto
1327028d44 Merge pull request #471 from mitchellh/mode-warning
macos, gtk: show warning when running with debug build
2023-09-15 16:03:04 -07:00
Will Pragnell
8f2ab46e1e windows: use cross platform consts where available 2023-09-15 16:01:33 -07:00
Mitchell Hashimoto
2dccf4596a macos: consistent text 2023-09-15 15:58:14 -07:00
Mitchell Hashimoto
120588fb62 apprt/gtk: show warning when running debug version 2023-09-15 15:57:51 -07:00
Mitchell Hashimoto
f8fea2f65b macos: show warning in debug mode 2023-09-15 15:40:41 -07:00