Mitchell Hashimoto
e2b5bfb5b0
gtk: fix comment about adwaita version ( #7274 )
2025-05-06 07:04:32 -07:00
Mitchell Hashimoto
f13d74bcf0
improvements to the Issue Triage Discussion template ( #7266 )
...
After some time with the initial template and Discussions being created,
there are some improvements we should make to the Issue Triage template.
Most of these changes were discussed in #7012 and among helpers in the
Discord.
~~I've marked this as a Draft for now as I work with the helpers to
confirm how we want to approach a few of the outstanding changes, mostly
minor updates.~~
As always, you can test these out by [opening an Issue Triage Discussion
post on my
fork](https://github.com/taylrfnt/ghostty/discussions/new?category=issue-triage ).
2025-05-06 06:57:36 -07:00
Mitchell Hashimoto
b346f06a51
Update iTerm2 colorschemes ( #7268 )
...
Upstream revision:
1e4957e650
2025-05-06 06:56:49 -07:00
Jeffrey C. Ollie
1bf686d324
gtk: fix comment about adwaita version
2025-05-06 08:44:52 -05:00
taylrfnt
ac11ebbb4a
update applied label to proper name
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-05 21:37:49 -05:00
taylrfnt
ad0d426bba
consistent spacing with tip & important highlights
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-05 21:36:38 -05:00
taylrfnt
d0b9242f49
replace dashes with code block backticks for additional config
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-05 21:34:33 -05:00
taylrfnt
f9c1b6b7cf
fixup markdown in additional config field
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-05 19:28:31 -05:00
taylrfnt
ad16f984cf
remove smart quotes in favor of ascii
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-05 19:27:08 -05:00
taylrfnt
f84367880b
Properly enclose code block backticks
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-05 19:23:40 -05:00
Jon Parise
37974dba06
bash: explicitly request a login shell
...
Prior to #7044 , on macOS, our shell integrated command line would be
executed under `exec -l`, which caused bash to be started as a login
shell. Now that we're using direct command execution, add `--login` to
our bash command's arguments on macOS to get that same behavior.
2025-05-05 10:26:37 -04:00
taylrfnt
11db0ed8ae
re-apply formatting & overwrite, not append
2025-05-04 12:17:29 -05:00
taylrfnt
8dfa6beb15
add acknowledgement for previewing format before submitting
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-04 12:04:09 -05:00
taylrfnt
431116c9d8
do not ask users for a summary
2025-05-04 12:01:22 -05:00
taylrfnt
46d3de26fc
remove renderers prone to jailbreak
2025-05-04 11:59:57 -05:00
taylrfnt
233ef4f782
more updates to expected behavior placeholder
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-04 11:58:50 -05:00
taylrfnt
050375cbb6
make minimum configuration more explicit
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-03 21:56:08 -05:00
taylrfnt
cc95475ae9
update placeholder text
...
remove the 'example:' prefixes and make them sound less like it's AI-generated
2025-05-03 21:48:59 -05:00
taylrfnt
1f9a4e6794
more direct naming of minimal configuration
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-03 21:38:19 -05:00
taylrfnt
0bf168c834
terminal inspector no longer proper noun
2025-05-03 21:38:19 -05:00
taylrfnt
6ffb6207e7
split out expected & actual behavior fields
2025-05-03 21:38:19 -05:00
taylrfnt
9c2f8d8ad3
cleanup the input issue hint
...
Co-authored-by: trag1c <dev@jakubr.me>
2025-05-03 21:38:19 -05:00
taylrfnt
51b6925322
add Linux log hint
2025-05-03 21:38:19 -05:00
taylrfnt
41e3c8830f
change VT to terminal emulation
...
Co-authored-by: Leah Amelia Chen <hi@pluie.me>
2025-05-03 21:37:50 -05:00
taylrfnt
71f52fd198
re-order ghostty logs field
2025-05-03 20:53:00 -05:00
taylrfnt
4d27fc18eb
use log stream command instead of link to discussion
...
Co-authored-by: Kat <65649991+00-kat@users.noreply.github.com>
2025-05-03 20:50:04 -05:00
mitchellh
abf5f18598
deps: Update iTerm2 color schemes
2025-05-04 00:14:51 +00:00
Mitchell Hashimoto
b6f338065e
ci: workaround broken lxd start with snap builder ( #7267 )
...
https://discourse.ubuntu.com/t/lxd-doesn-t-start-snap-lxd-device-directory-nonexistent/59785
https://github.com/canonical/lxd-pkg-snap/pull/789
This is required until Namespace or further upstream fixes are made.
2025-05-03 15:05:33 -07:00
Mitchell Hashimoto
e174599533
ci: workaround broken lxd start with snap builder
...
https://discourse.ubuntu.com/t/lxd-doesn-t-start-snap-lxd-device-directory-nonexistent/59785
https://github.com/canonical/lxd-pkg-snap/pull/789
This is required until Namespace or further upstream fixes are made.
2025-05-03 13:20:00 -07:00
taylrfnt
60e1a73c04
update log textarea render to display inputs in codeblock
2025-05-03 14:45:53 -05:00
taylrfnt
10dcf1dfe9
fix most of the feedback from 7012
2025-05-03 14:40:34 -05:00
Mitchell Hashimoto
040cdba707
flatpak: update GNOME runtime to 48 ( #7261 )
...
Notable dependencies updates:
- GTK 4.16.13 -> 4.18.4
- Libadwaita 1.6.6 -> 1.7.2
2025-05-03 06:57:33 -07:00
Leorize
c0f41aba45
flatpak: update GNOME runtime to 48
...
Notable dependencies updates:
- GTK 4.16.13 -> 4.18.4
- Libadwaita 1.6.6 -> 1.7.2
2025-05-02 14:24:02 -05:00
Mitchell Hashimoto
464b85b64c
codeowners: correct shell_integration.zig filename ( #7255 )
2025-05-02 08:25:27 -07:00
Jon Parise
b2138eeaf0
codeowners: correct shell_integration.zig filename
2025-05-02 10:59:52 -04:00
Qwerasd
5319d38366
fix(tests): correctly deinit font faces
2025-05-01 18:37:47 -06:00
Qwerasd
cfedd477b2
font/freetype: introduce mutexes to ensure thread safety of Library and Face
...
For details see comments and FreeType docs @
https://freetype.org/freetype2/docs/reference/ft2-library_setup.html#ft_library
https://freetype.org/freetype2/docs/reference/ft2-face_creation.html#ft_face
tl;dr: FT_New_Face and FT_Done_Face require the Library to be locked for
thread safety, and FT_Load_Glyph and FT_Render_Glyph and friends need
the face to be locked for thread safety, since we're sharing faces
across threads.
2025-05-01 18:22:37 -06:00
Maciej Bartczak
418c46538c
use enum for the color scheme args
2025-05-01 19:41:02 +02:00
Maciej Bartczak
0b5160e9f0
implement dark/light theme filtering in theme preview
2025-05-01 19:02:34 +02:00
Mitchell Hashimoto
e79bf71f23
Binding for toggling window float on top (macOS only) ( #7246 )
...
This adds a keybinding and apprt action for #7237 .
2025-05-01 09:51:09 -07:00
Mitchell Hashimoto
6e11d947e7
Binding for toggling window float on top (macOS only)
...
This adds a keybinding and apprt action for #7237 .
2025-05-01 09:47:17 -07:00
Mitchell Hashimoto
a6fd499019
macos: add float on top feature for terminal windows ( #7237 )
...
Closes #5188
**See:**
-
https://github.com/ghostty-org/ghostty/discussions/5188#discussioncomment-12607781
-
https://github.com/ghostty-org/ghostty/discussions/5188#discussioncomment-12984898
2025-05-01 09:24:15 -07:00
Martin Hettiger
f83729ba48
macos: add float on top feature for terminal windows
2025-05-01 09:13:33 -07:00
Mitchell Hashimoto
4b3a49a56e
apprt/gtk: ensure configuration is loaded on startup ( #7241 )
...
Restores the app configuration code removed in
https://github.com/ghostty-org/ghostty/pull/6792 .
The was unnoticed due to `colorSchemeEvent` triggering a configuration
reload if `window-theme` deviates from the default (i.e. dark mode is
used).
Fixes https://github.com/ghostty-org/ghostty/discussions/7206
2025-05-01 08:30:22 -07:00
Leorize
0af5a291ac
apprt/gtk: ensure configuration is loaded on startup
...
Restores the app configuration code removed in
https://github.com/ghostty-org/ghostty/pull/6792 .
The was unnoticed due to `colorSchemeEvent` triggering a
configuration reload if `window-theme` deviates from the default
(i.e. dark mode is used).
Fixes https://github.com/ghostty-org/ghostty/discussions/7206
2025-05-01 01:59:36 -05:00
Leah Amelia Chen
2b4f1f8b84
Improve the documentation for gtk-custom-css
( #7190 )
...
Recently when answering [a Discussion], I was reminded of when Tristan
once linked the GTK CSS documentation and said “Perhaps good to add this
to the docs of the GTK custom CSS config option”, so I decided to do
that now. I also added a few random things that I found helpful when
attempting to modify Ghostty's CSS; this information was mostly stolen
from random people on Discord or accidentally discovered.
I really do not care if this is merged or not, nor do I care if the
strings are changed considerably[^1], so I am going straight for a Pull
Request without bothering to open a Discussion, get that converted to an
Issue after a few years, then finally remember to open a Pull Request.
I only tested what this looks like in `ghostty +show-config --default
--docs`, the manpage and the HTML output; I notably did not try seeing
how it renders on the website. The links have to be in angle brackets
for the HTML output to have it rendered as URLs, but it looks odd
everywhere else; manpages have them with mathematical angle brackets,
⟨like this⟩. I also refrained from using an em (—) or en (–) dash
instead of a normal dash (-) as that does not seem to be common in the
rest of the documentation.
[a Discussion]: https://github.com/ghostty-org/ghostty/discussions/7189
[^1]: I didn't see any guidelines or standards for these strings, so
presumably these would be contested as I didn't know what to adhere to
when writing them.
2025-04-30 22:33:11 +02:00
Morgan
6f4fe56b93
Add comment about gl-no-fractional
2025-04-30 23:50:11 +09:00
Mitchell Hashimoto
ff536e34d6
i18n: fixed the translation for Russian ( #7218 )
...
The problem was highlighted in
https://github.com/ghostty-org/ghostty/pull/7127#discussion_r2051223171
In Russian, the words
[`затем`](https://ru.wiktionary.org/wiki/%D0%B7%D0%B0%D1%82%D0%B5%D0%BC )
and [`либо`](https://ru.wiktionary.org/wiki/%D0%BB%D0%B8%D0%B1%D0%BE )
are written separately.
@zeshi09 @TicClick take a look?
2025-04-30 07:02:21 -07:00
Morgan
5291292047
Add runtimeUntil
, fix remove GDK_DEBUG gl-no-fractional
2025-04-30 15:58:21 +09:00
Tim Culverhouse
b3edc88010
terminal(dcs): convert all xtgettcap queries to upper ( #7230 )
...
XTGETTCAP queries are a semicolon-delimited list of hex encoded terminfo
capability names. Ghostty encodes a map using upper case hex encodings,
meaning when an application uses a lower case encoding the capability is
not found. To fix, we convert the entire list we receive in the query to
upper case prior to processing further.
Fixes : #7229
2025-04-29 19:06:25 -05:00