7063 Commits

Author SHA1 Message Date
Mitchell Hashimoto
a3247366fb font/coretext: font-thicken renders with additional padding on context
At certain font sizes, this avoids clipping the text. This is due to a
limitation of the CoreText API, which does not provide a way to measure
the exact size of the text that will be rendered when antialiasing is
enabled.
2024-08-19 20:47:39 -07:00
Mitchell Hashimoto
cac22bd173 Merge pull request #2121 from ghostty-org/keyseq
Sequenced Keybindings
2024-08-19 18:08:37 -07:00
Mitchell Hashimoto
bec5772d77 config: warn the hazards of '>' for sequences 2024-08-19 12:56:51 -07:00
Mitchell Hashimoto
295ef384a6 core: centralize key sequence ending in one function 2024-08-19 12:41:33 -07:00
Mitchell Hashimoto
99b3e2e844 core: clear pending keyboard sequence when config reloads 2024-08-19 12:33:29 -07:00
Mitchell Hashimoto
454c585eb3 core: handle unconsumed key sequences 2024-08-19 12:28:00 -07:00
Mitchell Hashimoto
4ce7a88dee core: enable key sequence handling, including dumping invalid 2024-08-19 12:22:52 -07:00
Mitchell Hashimoto
3a952de272 core: encodeKey should return a write request 2024-08-19 12:14:29 -07:00
Mitchell Hashimoto
08ba00246b core: release events should never trigger bindings 2024-08-19 12:04:09 -07:00
Mitchell Hashimoto
203e33c416 core: move key handling (w/o bindings) out to a separate func
This is going to let us have a central place we can encode all the
inputs up to an invalid binding.
2024-08-19 10:54:02 -07:00
Mitchell Hashimoto
4201a580f3 core: rework binding handling to prepare for nested binding sets 2024-08-19 10:41:37 -07:00
Mitchell Hashimoto
443a5e12e7 Merge pull request #2119 from bschaatsbergen/d/add-deps-instruction
docs: add installing dependencies
2024-08-19 09:09:20 -07:00
Bruno Schaatsbergen
8fa71d3b90 chore: rm run 2024-08-19 18:00:01 +02:00
Bruno Schaatsbergen
acb9908e3c docs: add deps install
Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
2024-08-19 09:53:58 -04:00
Jeffrey C. Ollie
a2ef0ca751 Address review comments.
- Cap the total number of requests at twice the maximum number of
  keys (currently 263, so 526 requests). Basically you can set and then
  query every key in one message. This is an absurdly high number
  but should prevent serious DOS attacks.
- Clarify meaning of new hex color codes.
- Better handle sending messages to the renderer in a way that should
  prevent deadlocks.
- Handle 0-255 palette color requests by creatively using non-exhautive
  enums.
- Fix an error in the query reply.
2024-08-19 00:22:09 -05:00
Mitchell Hashimoto
ec050407ee input: remove unused struct 2024-08-18 20:58:35 -07:00
Mitchell Hashimoto
2da2cee704 input: remove the old parse method for bindings 2024-08-18 20:58:35 -07:00
Mitchell Hashimoto
6d2cbb0703 config: write the docs now for sequences 2024-08-18 20:30:33 -07:00
Mitchell Hashimoto
9577c8b8b9 core: log when we see a leader 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
43176c750e config: support equality checking keybinds with sequences 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
9944f5d34d input: Binding.Set.clone handles leaders 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
bfb31c374e input: binding set needs to clean up leader memory on manual put 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
2bf20ec32c fix compilation but logic broken 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
39d91741e0 input: remove todo 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
2f71eb6f99 input: unwind properly on unbind 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
64a68eeaff input: more parseAndPut tests 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
c71615c467 input: binding.set can parse sequences... lots TODO 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
7dfad49e40 input: converting set entries to Entry from Action 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
bc4eab4af7 input: add Set.parseAndPut 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
a798a26063 input: binding parser of sequences 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
e2913fd16f input: SequenceIterator to parse sequences of triggers 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
63ec5cdd9d input: Trigger.parse 2024-08-18 20:30:32 -07:00
Mitchell Hashimoto
1fd9cf2d08 Merge pull request #2089 from jcollie/theme-updates
Theme updates
2024-08-18 19:48:18 -07:00
Mitchell Hashimoto
00f642a28f typos 2024-08-18 19:34:26 -07:00
Mitchell Hashimoto
ea0e3057ca config: fix build on iOS for error set 2024-08-18 19:31:54 -07:00
Mitchell Hashimoto
b79d80dc82 Fix broken import from rebase 2024-08-18 19:23:49 -07:00
Mitchell Hashimoto
c7e0173158 config: remove unused types and function 2024-08-18 19:20:42 -07:00
Jeffrey C. Ollie
7de692c955 themes: don't use arena directly and cleanup debug code 2024-08-18 19:20:42 -07:00
Jeffrey C. Ollie
50c31ba173 themes: fix comment 2024-08-18 19:20:42 -07:00
Jeffrey C. Ollie
8c4cfc3bbb themes: finish refactor 2024-08-18 19:20:42 -07:00
Mitchell Hashimoto
5e33d77160 config: use else to catch all errors since there are many 2024-08-18 19:20:42 -07:00
Mitchell Hashimoto
d3182c8d7c config: move theme loading to dedicated file 2024-08-18 19:20:42 -07:00
Jeffrey C. Ollie
87791ed562 themes: add a switch that shows a small preview of each theme 2024-08-18 19:20:42 -07:00
Jeffrey C. Ollie
7a11b22c5f themes: allow loading from absolute paths and from user config dir 2024-08-18 19:20:42 -07:00
Mitchell Hashimoto
f7f55d716d Merge pull request #2118 from ghostty-org/push-ymywukppmvvu
readme: clarify that comments are only allowed on a dedicated line
2024-08-18 19:04:13 -07:00
Mitchell Hashimoto
6877ba9f7f readme: clarify that comments are only allowed on a dedicated line 2024-08-18 19:01:47 -07:00
Mitchell Hashimoto
37d19b3cef Merge pull request #2109 from edmz/block_hollow
Config: cursor-style can bet set to block_hollow
2024-08-18 15:08:08 -07:00
Mitchell Hashimoto
18a8d2b01d Minor changes, mainly commenting to clarify some behaviors 2024-08-18 15:05:31 -07:00
Mitchell Hashimoto
df9725a142 Merge pull request #2117 from ghostty-org/extend-covering
renderer: use fg as extension color for covering glyphs (U+2588)
2024-08-18 12:02:02 -07:00
Mitchell Hashimoto
2ee54879a4 renderer: use fg as extension color for covering glyphs (U+2588)
Fixes #2099

This is another heuristic of sorts to make `window-padding-color=extend`
look better by default. If a fully covering glyph is used then we use
the fg color to extend rather than the background.

This doesn't account for fonts that may do this for whatever codepoints,
but I think that's a special scenario that we should just recommend
disabling this feature.
2024-08-18 11:56:50 -07:00