Tim Culverhouse
723d79c9de
graphics: set default transmission format as .rgba
...
The default format for transmission is defined as RGBA (f=32) in the
Kitty Graphics specification. When no format is specified, this can
result in an error for length checking.
Fixes : #2212
Reference: https://sw.kovidgoyal.net/kitty/graphics-protocol/#control-data-reference
2024-09-10 11:03:51 -07:00
Leah Amelia Chen
8502034dae
README: document common issues on NixOS
2024-09-09 10:45:44 +02:00
Mitchell Hashimoto
12bf107bcb
update README
2024-09-08 21:30:07 -07:00
Mitchell Hashimoto
d4feae67c8
Merge pull request #2207 from mohshami/fedora_install_doc
...
Add package names for Fedora variants
2024-09-08 09:40:11 -07:00
Mohammad H. AlShami
20fdd6ee9f
Fix copied mistake
2024-09-07 13:10:59 -05:00
Mohammad H. AlShami
4ee615294b
Add package names for Fedora variants
2024-09-07 13:06:36 -05:00
Mitchell Hashimoto
4501991325
Merge pull request #2201 from qwerasd205/wide-boundary-conds
...
Wide cell boundary conditions in ECH & DCH + soft-wrap reset correctness
2024-09-06 19:00:15 -07:00
Qwerasd
5138801b7b
comment
2024-09-06 18:03:56 -04:00
Qwerasd
9669332134
terminal: cursorResetWrap should not reset wrap_continuation
2024-09-06 17:57:14 -04:00
Mitchell Hashimoto
8f47581e22
terminal: add test for wide character on right margin boundary
2024-09-06 14:28:04 -07:00
Mitchell Hashimoto
f4052fd824
terminal: fix uninitialized memory access when kitty color protocol
2024-09-06 14:08:33 -07:00
Qwerasd
057f218c9e
perf(terminal): specialize splitCellBoundary
to cursor row
...
+ do some abstraction leakage in `cursorResetWrap`, since they're both
used in hot functions for TUI stuff so performance is important.
2024-09-06 13:26:57 -04:00
Mitchell Hashimoto
c16a4fd95e
Merge pull request #2203 from ghostty-org/crash-envelope
...
Crash envelope rich decoding, fix parsing multiple items, serialization
2024-09-06 09:53:37 -07:00
Mitchell Hashimoto
b2696ee6fa
crash: envelope parsing handles multiple payloads with length properly
2024-09-06 09:48:21 -07:00
Qwerasd
8d12044f1d
Terminal: fix ECH & DCH wide char boundary cond. behavior
2024-09-06 12:35:11 -04:00
Qwerasd
04271c6a07
test(Terminal): test ECH wide char boundary conditions
2024-09-06 12:35:11 -04:00
Qwerasd
1692a82b33
test(Terminal): test DCH wide char boundary conditions
2024-09-06 12:35:11 -04:00
Mitchell Hashimoto
4acbdbc038
typos
2024-09-06 09:23:33 -07:00
Mitchell Hashimoto
646b8a4cdd
crash: parse attachments from sentry envelope
2024-09-06 09:21:36 -07:00
Mitchell Hashimoto
6788aefe95
crash: data model for encoded vs decoded items
2024-09-06 08:50:18 -07:00
Mitchell Hashimoto
ee6fd80746
crash: envelope encoder
2024-09-05 21:24:14 -07:00
Mitchell Hashimoto
cc59c5d5d9
Merge pull request #2202 from ghostty-org/push-xqxploovxolw
...
font/sprite: avoid invalid glyph if unsupported codepoint is attempted
2024-09-05 20:26:41 -07:00
Mitchell Hashimoto
c9523a6ee0
font/sprite: avoid invalid glyph if unsupported codepoint is attempted
2024-09-05 20:22:51 -07:00
Mitchell Hashimoto
eec2b1e3e8
Merge pull request #2200 from tristan957/gtk-accel-warning
...
gtk: silence bad accelerator warnings
2024-09-05 18:20:53 -07:00
Tristan Partin
a0bc6ae966
gtk: silence bad accelerator warnings
...
Before this a commit a keybind of CTRL + \ would create a GTK
accelerator of <Ctrl>\, which is incorrect. It needs to be
<Ctrl>backslash, which can be retrieved with gdk_keyval_name().
Signed-off-by: Tristan Partin <tristan@partin.io>
2024-09-05 19:08:29 -05:00
Mitchell Hashimoto
0f4d07e68c
Merge pull request #2199 from ghostty-org/osc
...
terminal: do not reset OSC parser if its already empty
2024-09-05 16:58:25 -07:00
Mitchell Hashimoto
738a4c568a
terminal: do not reset OSC parser if its already empty
...
This is not a safe operation since the OSC parser has undefined memory
when it is in the empty state. This is on purpose for performance
reasons.
2024-09-05 16:53:34 -07:00
Mitchell Hashimoto
b283307dd6
update vouch instructions
2024-09-05 15:17:00 -07:00
Mitchell Hashimoto
ce85eb1d91
readme: update vouch help
2024-09-05 15:13:13 -07:00
Mitchell Hashimoto
e5bc7d5772
Merge pull request #2198 from ghostty-org/decaln
...
DECALN must clear protected cells (fixes managed memory leak in page)
2024-09-05 14:43:32 -07:00
Mitchell Hashimoto
693755693a
terminal: can't assert page integrity on screen
2024-09-05 14:41:02 -07:00
Mitchell Hashimoto
a6031efa04
terminal: DECALN must use clearRows to clear protected memory
2024-09-05 14:35:12 -07:00
Mitchell Hashimoto
f0149722e6
terminal: add integrity check for unmarked grapheme cell
2024-09-05 14:17:11 -07:00
Mitchell Hashimoto
a3aa5463a1
Revert "Merge pull request #2060 from jcollie/gtk-compatibility"
...
This reverts commit 9ce789cc85d411c59eff2a01c7fe18ce14ccd2b8, reversing
changes made to f1aea10a84176ff4338f7d2f0bf1b9c700b41baa.
2024-09-05 08:45:37 -07:00
Mitchell Hashimoto
2c48e86a86
Merge pull request #2196 from gpanders/push-oxsosnpoxtwz
...
termio: send initial focus reports
2024-09-04 20:56:59 -07:00
Gregory Anders
df06697899
termio: send initial focus reports
...
When the focus reporting mode (1004) is enabled, send the current focus
state. This allows applications to track their own focus state without
first having to wait for a focus event (or query
it by sending a DECSET followed by a DECRST).
Ghostty's focus state is stored only in the renderer, where the termio
thread cannot access it. We duplicate the focus state tracking in the
Terminal struct with the addition of a new (1-bit) flag. We duplicate
the state because the renderer uses the focus state for its own purposes
(in particular, the Metal renderer uses the focus state to manage
its DisplayLink), and synchronizing access to the shared terminal state
is more cumbersome than simply tracking the focus state in the renderer
in addition to the terminal.
2024-09-04 22:13:52 -05:00
Mitchell Hashimoto
42b799e9a0
Merge pull request #2194 from jcollie/wuffs-blend-mode
...
wuffs: fix blend mode
2024-09-04 16:58:35 -07:00
Jeffrey C. Ollie
f2d53b451b
wuffs: fix blend mode
2024-09-04 18:23:54 -05:00
Mitchell Hashimoto
2142ba53c4
apprt/gtk: do not remove unfocused widget from overlay
...
See comment
2024-09-04 14:17:51 -07:00
Mitchell Hashimoto
125982a5e2
Merge pull request #2191 from ghostty-org/push-uupwrypuzvsp
...
kitty gfx: handle `q` with chunked transmissions properly
2024-09-04 10:28:33 -07:00
Mitchell Hashimoto
761bcfad50
kitty gfx: handle q
with chunked transmissions properly
...
Fixes #2190
The `q` value with chunk transmissions is a bit complicated. The initial
transmission ("start" command) `q` value is used for all subsequent
chunks UNLESS a subsequent chunk specifies a `q >= 1`. If a chunk
specifies `q >= 1`, then that `q` value is subsequently used for all
future chunks unless another chunk specifies `q >= 1`. And so on.
This commit importantly also introduces the ability to test a full Kitty
command from string request to structured response. This will let us
prevent regressions in the future and ensure that we are correctly
handling the complex underspecified behavior of Kitty Graphics.
2024-09-04 10:24:25 -07:00
Mitchell Hashimoto
3e9163e4c6
Merge pull request #2189 from ghostty-org/dependabot/github_actions/namespacelabs/nscloud-cache-action-1.1.7
...
build(deps): bump namespacelabs/nscloud-cache-action from 1.1.6 to 1.1.7
2024-09-03 18:18:01 -07:00
dependabot[bot]
2cfdd29535
build(deps): bump namespacelabs/nscloud-cache-action from 1.1.6 to 1.1.7
...
Bumps [namespacelabs/nscloud-cache-action](https://github.com/namespacelabs/nscloud-cache-action ) from 1.1.6 to 1.1.7.
- [Release notes](https://github.com/namespacelabs/nscloud-cache-action/releases )
- [Commits](https://github.com/namespacelabs/nscloud-cache-action/compare/v1.1.6...v1.1.7 )
---
updated-dependencies:
- dependency-name: namespacelabs/nscloud-cache-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-09-04 01:00:59 +00:00
Mitchell Hashimoto
339a83c89d
config: note that emoji font requires explicit override
...
Fixes #2072
2024-09-03 15:32:44 -07:00
Mitchell Hashimoto
1f08478178
Merge pull request #2188 from ghostty-org/push-qltovxupnrxr
...
nix: remove ZLS
2024-09-03 15:21:42 -07:00
Mitchell Hashimoto
a9deb37071
nix: remove ZLS
...
Fixes #2171
ZLS has caused us issues in our Nix shell before and I noted when we
first added it that we probably shouldn't. We now pin to release
versions of Zig so I think its reasonable to expect developers to have
ZLS installed themselves with the proper version or not use it at all.
2024-09-03 15:18:04 -07:00
Mitchell Hashimoto
f0c4afdf9c
termio: set crash threadlocal data for exec reader thread
2024-09-03 14:31:05 -07:00
Mitchell Hashimoto
f45cde0b95
Merge pull request #2187 from ghostty-org/kitty-kbd
...
kitty kbd: progressive enhancement `=` mode off by one
2024-09-03 12:03:03 -07:00
Mitchell Hashimoto
e014c68cf0
kitty kbd: progressive enhancement =
mode off by one
...
Fixes #2161
2024-09-03 11:59:25 -07:00
Mitchell Hashimoto
12efa8ec24
Merge pull request #2186 from ghostty-org/kitty-fix
...
kitty graphics: respond OK with metadata on display actions
2024-09-03 11:11:33 -07:00