Mitchell Hashimoto
ce73917325
Merge pull request #2285 from ghostty-org/push-lwxwvlyootok
...
macos: cannot call mouseEntered/Exited with blank NSEvent
2024-09-22 10:28:07 -07:00
Mitchell Hashimoto
554dd6ff95
macos: enable dead code stripping
...
This is a recommended Xcode setting, the binary _seems_ to run fine.
It eliminates a warning from builds and reduces the binary size.
2024-09-22 10:21:51 -07:00
Mitchell Hashimoto
c63af5efaa
macos: cannot call mouseEntered/Exited with blank NSEvent
...
Fixes #2283
macOS <= 14 crash with an invalid NSEvent error. macOS 15 seems to just
ignore the blank event. We just got lucky with this. Since we don't
override mouseEntered/Exited anymore we can remove this completely.
The regression was from: e89a4f74089b66c00043096589dc75fff5ab6674
2024-09-22 10:17:45 -07:00
Mitchell Hashimoto
6607ffa7f4
Merge pull request #2280 from iceghost/vtebench-fix
...
fix(terminal/PageList): ensure enough pages before first page reuse
2024-09-21 21:09:53 -07:00
Mitchell Hashimoto
f858ae13ae
terminal: clarify comment
2024-09-21 21:05:46 -07:00
Mitchell Hashimoto
f0eb5d0d43
terminal: test for scenario where grow() has to prune with a single page
...
See comments in the test, also this:
> The scenario is if you adjustCapacity a page beyond a std_size then our
> precondition no longer holds. PageList.adjustCapacity makes no guarantee
> that the resulting capacity fits within a standard page size. It is in fact
> documented this way and that it is slow since we have to mmap out of our
> memory pool.
2024-09-21 21:05:01 -07:00
Mitchell Hashimoto
204212afcf
Merge pull request #2282 from ghostty-org/movemods
...
apprt/macos,gtk: unfocused splits now highlight hovered links
2024-09-21 15:28:05 -07:00
Mitchell Hashimoto
261ce00552
apprt/macos,gtk: unfocused splits now highlight hovered links
...
Fixes #1547
The core change to make this work is to make the cursor position
callback support taking updated modifiers. On both macOS and GTK, cursor
position events also provide the pressed modifiers so we can pass those
in.
2024-09-21 15:16:14 -07:00
Mitchell Hashimoto
fb6cd7a8fa
Merge pull request #2281 from ghostty-org/pointer
...
macOS: Use macOS 15 APIs to stabilize cursor hide while typing
2024-09-21 14:40:55 -07:00
Mitchell Hashimoto
d090384600
macos: fix non-AppKit builds
2024-09-21 10:22:14 -07:00
Mitchell Hashimoto
3769c83bdf
config: note that mouse hide while typing on macos requires 15+
2024-09-21 10:03:57 -07:00
Mitchell Hashimoto
7f56ea150d
typos
2024-09-21 10:00:32 -07:00
Mitchell Hashimoto
f9bd009ce5
macos: unhide cursor on clipboard confirmation
2024-09-21 09:59:40 -07:00
Khang Nguyen Duy
d5ab772b66
fix(terminal/PageList): ensure enough pages before first page reuse
...
Running alacritty/vtebench on some machines causes Ghostty to fail on
`assert(first != last)` when trying to grow scrollback. We now make sure
we have enough pages before trying to reuse pages.
2024-09-21 22:03:06 +07:00
Mitchell Hashimoto
c01bdc6d7c
macos: use pointerStyle for SplitView Divider
2024-09-20 22:02:21 -07:00
Mitchell Hashimoto
0e1258b7fe
macos: pointer style uses macOS 15 helpers
2024-09-20 22:02:21 -07:00
Mitchell Hashimoto
e89a4f7408
macos: use macOS 15 pointerVisibility to show/hide cursor
2024-09-20 22:02:20 -07:00
Mitchell Hashimoto
c6bbdfb7bf
macos: remove EventSinkHostingView
...
This was breaking various other features:
- Popovers stopped working
- Split divider drag gestures stopped working
For now we document the top part of the window is draggable... we
can look into removing that limitation later.
2024-09-20 22:01:01 -07:00
Mitchell Hashimoto
2c44e20860
macos: EventSinkHostingView must not override mouse events
...
This breaks split resizing. Removing this doesn't seem to have negative
effects for hidden titlebars (which it was originally made for).
2024-09-20 21:40:30 -07:00
Mitchell Hashimoto
44e39326b3
Merge pull request #2276 from qwerasd205/macos-titlebar-hidden
...
macOS: add `macos-titlebar-style = hidden`
2024-09-20 20:50:27 -07:00
Mitchell Hashimoto
578aaa1ba6
macos: DraggableWindowView helper (unused currently)
2024-09-20 20:45:27 -07:00
Mitchell Hashimoto
962aa49a45
macos: remove nstitlecontainerview hidden
2024-09-20 19:18:01 -07:00
Mitchell Hashimoto
5af3d8470a
Merge pull request #2277 from ghostty-org/kill
...
termio: killpg expected to fail on darwin, still go into waitpid loop
2024-09-20 18:58:57 -07:00
Mitchell Hashimoto
f8bdd2b1bb
termio: killpg expected to fail on darwin, still go into waitpid loop
...
Fixes #2273
On macOS, killpg is expected to fail with EPERM because of the way we
launch a login process around it. Before this commit, this caused us to
never call waitpid and reap the child process, which caused the child
process to stick around as a zombie.
This commit allows killpg to fail with EPERM on macOS and fall through
to waitpid.
2024-09-20 15:29:06 -07:00
Qwerasd
ae46ff6854
mention macos-titlebar-style = hidden in window-decoration docs
2024-09-20 16:18:42 -06:00
Qwerasd
16919488da
macOS: add macos-titlebar-style = hidden
...
Hides titlebar without removing the other typical window frame elements
2024-09-20 16:11:51 -06:00
Mitchell Hashimoto
f5c83d62d7
Merge pull request #2275 from ghostty-org/sipointer
...
macos: show clickable mouse pointer when hovering over secure input
2024-09-20 14:08:24 -07:00
Mitchell Hashimoto
08ee0c1038
ci: use xcode 16
2024-09-20 13:47:46 -07:00
Mitchell Hashimoto
df24d8e1a6
macos: show clickable mouse pointer when hovering over secure input
...
This only works on macOS 15 because it uses the new `pointerStyle` API.
I don't have the interest to backport this to older macOS versions but
I'm happy to accept a PR if someone else wants to do it.
2024-09-20 09:56:44 -07:00
Mitchell Hashimoto
761223f0f3
Merge pull request #2274 from FineFindus/fix/comment
...
termio: correct comment about windows support
2024-09-20 09:15:12 -07:00
FineFindus
6f3db36251
termio: correct comment about windows support
...
The comment has conflicting information about supporting windows. This
removes the incorrect information that only windows is supported.
2024-09-20 17:42:08 +02:00
Mitchell Hashimoto
a503e0250e
apprt/gtk: add version helpers
...
This adds version helpers similar to the adwaita version helpers so that
build time and runtime version checks can be done.
2024-09-19 20:24:52 -07:00
Severus
888861984d
Fix typo
2024-09-20 10:18:19 +07:00
Mitchell Hashimoto
38eb9071eb
Merge pull request #2270 from ghostty-org/secureinput
...
macOS Secure Input
2024-09-19 20:15:35 -07:00
Mitchell Hashimoto
df5cd719d6
macos: rename overlay config to indication
2024-09-19 20:00:46 -07:00
Mitchell Hashimoto
08a2a71ab8
macos: copy
2024-09-19 19:57:03 -07:00
Mitchell Hashimoto
fa9df4f6f0
macos: persist secure input state across restarts
2024-09-19 19:54:53 -07:00
Severus
b675905cc2
Fix 2271 issue
...
From GTK 4.16, GDK_DEBUG is splitted into GDK_DEBUG and GDK_DISABLE
2024-09-20 07:55:40 +07:00
Mitchell Hashimoto
a513a02328
config: config to disable auto secure input and secure input overlay
2024-09-19 17:20:54 -07:00
Mitchell Hashimoto
ced8395c77
macos: copy changes
2024-09-19 17:06:49 -07:00
Mitchell Hashimoto
9f03aae764
ios: disable secure input
2024-09-19 16:56:46 -07:00
Mitchell Hashimoto
6b85a152d8
macos: fix deployment target back to 12.0
2024-09-19 16:43:43 -07:00
Mitchell Hashimoto
1ed1c73c1a
macos: enable secure input on password input
2024-09-19 16:38:32 -07:00
Mitchell Hashimoto
c3d6356a87
macos: show secure input overlay when it is enabled
2024-09-19 16:24:42 -07:00
Mitchell Hashimoto
c0e0eff468
core: add toggle_secure_input keybinding
2024-09-19 10:20:30 -07:00
Mitchell Hashimoto
0c38f40f0a
macos: secure input manager, global option in app
2024-09-19 10:11:31 -07:00
Mitchell Hashimoto
c26da4ea06
pkg/macos: expose carbon API
2024-09-19 09:22:07 -07:00
Mitchell Hashimoto
bfd88ffc5e
Merge pull request #2268 from ofseed/adw-disable-shortcuts
...
adw: disable all of the default shortcuts
2024-09-19 09:15:12 -07:00
Yi Ming
74411511df
refactor: remove the unnecessary ./ in imports
2024-09-19 15:35:52 +08:00
Yi Ming
2894e78cbe
adw: disable all of the default shortcuts
2024-09-19 15:15:47 +08:00
