6927 Commits

Author SHA1 Message Date
Matt Robenolt
9b233b2d47 macos: Declare Ghostty as a Shell
tbh I'm not exactly sure what this does, but Kitty/Hyper/iTerm2 all
declare this.

https://github.com/kovidgoyal/kitty/blob/master/setup.py#L1419-L1422
https://gitlab.com/gnachman/iterm2/-/blob/master/plists/release-iTerm2.plist#L120-127
https://github.com/vercel/hyper/blob/master/electron-builder.json#L72-L79

I'm trying to get Ghostty to work correctly with OrbStack: https://github.com/orbstack/orbstack/issues/1012

And this stood out as the biggest difference.
2024-05-21 11:00:03 -07:00
Mitchell Hashimoto
9ad598facf Merge pull request #1783 from mitchellh/dependabot/github_actions/cachix/cachix-action-15
build(deps): bump cachix/cachix-action from 14 to 15
2024-05-21 07:08:07 -04:00
Mitchell Hashimoto
3eedb88acc Merge pull request #1782 from tt/avoid-coloring-when-using-native-tabs
Avoid coloring when using native tabs
2024-05-21 07:07:47 -04:00
Troels Thomsen
f79674097f Avoid coloring when using native tabs 2024-05-21 08:58:51 +02:00
Mitchell Hashimoto
47874742a1 Extract guard statement 2024-05-21 08:58:10 +02:00
Troels Thomsen
242858b963 Color after setting window theme and tab mode 2024-05-21 08:05:55 +02:00
dependabot[bot]
d2323990ee ---
updated-dependencies:
- dependency-name: cachix/cachix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-21 00:26:05 +00:00
Mitchell Hashimoto
57e33319a3 Merge pull request #1781 from tt/recognize-system-theme
Recognize system theme
2024-05-20 19:12:17 -04:00
Mitchell Hashimoto
c700d69b8e Merge pull request #1780 from gpanders/open-error-log
os: log stderr from open command
2024-05-20 19:11:54 -04:00
Mitchell Hashimoto
1e60f7186c os: some stylistic changes, comments for stderr logging 2024-05-20 19:11:30 -04:00
Troels Thomsen
6366d562ca Recognize system theme 2024-05-19 23:01:09 +02:00
Gregory Anders
e710a59a43 os: log stderr from open command 2024-05-19 09:00:53 -05:00
Mitchell Hashimoto
f72c2ac615 Merge pull request #1777 from mitchellh/lru-slow
font/shaper: periodically reset LRU in cache to avoid slowdown
2024-05-18 10:21:24 -04:00
Mitchell Hashimoto
d7c64f57b1 font/shaper: periodically reset LRU in cache to avoid slowdown
See: https://github.com/ziglang/zig/issues/17851

Users were noticing that frame render times got slower over time. I
believe (thanks to community for pointing it out) that this is the
culprit.

This works around this issue by clearing and reinitializing the LRU
after a certain number of evictions. When the Zig issue has a better
resolution (either rehash() as a workaround or a better hash
implementation overall) we can change this.
2024-05-18 10:06:41 -04:00
Mitchell Hashimoto
eee58b9ce6 macos: titlebar styling always applies to titlebar tabs 2024-05-17 20:38:51 -04:00
Jeffrey C. Ollie
7c893881c3 Address review comments
1. Switch to using Wyhash instead of a cryptographic hash.
2. Move global variables to App struct.
2024-05-17 17:13:43 -05:00
Mitchell Hashimoto
6860af0161 Merge pull request #1776 from mitchellh/reload-transparency
macos: only set bg color and titlebar color if opaque
2024-05-17 17:11:46 -04:00
Mitchell Hashimoto
bc29076f07 Merge pull request #1765 from jparise/bash-command-option
shell-integration: handle 'bash -c command'
2024-05-17 17:08:44 -04:00
Mitchell Hashimoto
92d551a3c1 macos: only set bg color and titlebar color if opaque
Fixes #1771

I'm not convinced this fix won't regress some other behavior, but in my
titlebar tab and native tab modes with and without transparency, this
has looked okay to me.
2024-05-17 17:05:21 -04:00
Mitchell Hashimoto
add8c9b2c6 Merge pull request #1761 from qwerasd205/fix-link-highlight
fix(renderer/Metal): dirty track link highlights
2024-05-17 16:47:09 -04:00
Mitchell Hashimoto
6307162e49 small comment changes 2024-05-17 16:46:30 -04:00
Mitchell Hashimoto
6f93d1113a Merge pull request #1767 from peteschaffner/fix-title-bar-window-theme-regression
Fix title bar window theme regression
2024-05-17 16:31:42 -04:00
Mitchell Hashimoto
69a3137956 macos: use enum for window theme 2024-05-17 16:31:18 -04:00
Mitchell Hashimoto
6cff87e60e Merge pull request #1769 from mitchellh/dependabot/github_actions/cachix/install-nix-action-27
build(deps): bump cachix/install-nix-action from 26 to 27
2024-05-17 16:20:40 -04:00
ilk
a1a97913d3 refactor(shell-integration:elvish): refactor to improve readability 2024-05-17 18:11:00 +03:00
ilk
597328432c feat(shell-integration): add integration for Elvish
- contains `.elv` file that implements the core of Elvish integration.
- does not contain routines needed for automatic integration.
- stored in `./elvish/lib/...` in preparation for automatic integration:
  Elvish imports `.../elvish/lib/*.elv`.

checklist:
- no confirmation on close where the cursor is at prompt:
  works, only occasionally doesn't, I'm not yet sure when.
- new terminals start in pwd of previously focused terminal: works
- prompts resize correctly: works
- triple-click while holding `ctrl` selects output of a command:
  works (when mouse is over the output)
- cursor at the prompt is turned into a bar: works
- ghostty:`jump_to_prompt` scrolls through prompts: works
- `opt`-click moves cursor at the prompt: works
- `sudo` preserves ghostty terminfo:
   untested - not sure when this is needed exactly, but did not encounter
   any errors after sudo, either
2024-05-16 20:45:14 +03:00
dependabot[bot]
4498752665 build(deps): bump cachix/install-nix-action from 26 to 27
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 26 to 27.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v26...V27)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-16 00:28:23 +00:00
Pete Schaffner
c437416014 Make title/tab bar respect window-theme setting 2024-05-14 20:17:28 -04:00
Mitchell Hashimoto
cbcb4b27bc Merge pull request #1766 from jparise/bash-readme
shell-integration: update Bash integration details
2024-05-14 18:22:16 -04:00
Mitchell Hashimoto
56d61cb0c9 Merge pull request #1764 from jparise/bash-shellcheck
shell-integration: suppress shellcheck issues
2024-05-14 18:21:54 -04:00
Jon Parise
d5414d50ea shell-integration: update Bash integration details 2024-05-14 15:06:05 -07:00
Jon Parise
016c58cfe4 shell-integration: handle 'bash -c command'
When the -c option is present, then commands are read from the first
non-option argument command string. Our simple implementation assumes
that if we see at least the '-c' option, a command string was given, and
the shell is always considered to be non-interactive - even if the '-i'
(interactive) option is also given.
2024-05-14 11:01:49 -07:00
Jon Parise
11f3400e49 shell-integration: suppress shellcheck issues 2024-05-14 06:57:02 -07:00
Mitchell Hashimoto
c1eda22047 Merge pull request #1763 from mitchellh/vsync
config: default window-vsync to true
2024-05-14 07:22:18 -04:00
Mitchell Hashimoto
d7b37a9006 config: default window-vsync to true
Fixes #1409
Fixes macOS 14.4,14.5 kernel panics

As noted in the comment in this diff, I've decided to default this to
true because it fixes a couple _really bad_ issues for macOS users. For
macOS users on 14.4 and 14.5 (latest released as of this commit), this
resolves or at least heavily mitigates a possible kernel panic.

This also fixes #1409 where external displays over certain connections
such as DisplayLink would be unusably slow to render.
2024-05-14 07:19:15 -04:00
Qwerasd
4d67f660a4 fix(renderer/Metal): dirty track link highlights
Partial fix for link highlight dirty tracking. Some issues remain with
soft-wrapped links (see TODO in code), as well as pressing cmd while
hovering without moving the mouse at all doesn't highlight until you do
move the mouse for some reason.
2024-05-12 18:46:32 -04:00
Jeffrey C. Ollie
a89f817b9e adjust log message 2024-05-11 18:13:00 -05:00
Jeffrey C. Ollie
085c964be7 add strict rate limit 2024-05-11 18:13:00 -05:00
Jeffrey C. Ollie
b4404b691d suppress identical desktop notifications 2024-05-11 18:12:57 -05:00
Mitchell Hashimoto
7d22b42e01 Merge pull request #1758 from jcollie/gtk-menu-splits
Add split right & split down menu entries for the GTK apprt.
2024-05-11 16:02:00 -07:00
Jeffrey C. Ollie
aa9813bc79 Add split right & split down menu entries for the GTK apprt.
Inspired by #1752
2024-05-11 11:48:11 -05:00
Mitchell Hashimoto
edde6cd4db Merge pull request #1757 from mitchellh/point
macos: ime coordinate needs to be converted from view to window coords
2024-05-10 20:55:08 -07:00
Mitchell Hashimoto
d2adf0501c macos: ime coordinate needs to be converted from view to window coords
Fixes #1756

We previously converted from view to screen coordinates but if the view
doesn't take up the full window then the view coordinates are wrong. We
need to convert to window coordinates in the middle.
2024-05-10 20:45:51 -07:00
Mitchell Hashimoto
b4433cd364 Merge pull request #1755 from mitchellh/imgui
update Dear Imgui for Inspector to 1.90.6
2024-05-10 10:25:28 -07:00
Mitchell Hashimoto
a11c7ac785 update Dear Imgui to 1.90.6 2024-05-10 10:17:33 -07:00
Mitchell Hashimoto
103ebf6da5 Merge pull request #1752 from cryptocode/cc-split-menu-renaming
Rename Split Horizontally/Vertically to Split Right/Down
2024-05-10 09:46:08 -07:00
Mitchell Hashimoto
2783d758a4 Merge pull request #1754 from jparise/bash-preexec
shell-integration: update bash-preexec.sh
2024-05-10 09:44:38 -07:00
Jon Parise
baf5116140 shell-integration: update bash-preexec.sh
This pulls in a fix for `bind -x` bindings unintentionally calling the
preexec hook: https://github.com/rcaloras/bash-preexec/pull/152
2024-05-10 09:39:26 -07:00
Qwerasd
ac5725d582 fix(renderer): rebuild font grid and reset shaper cache on hot reload
When hot reloading config with a new font, shaper cache data needs to be
invalidated and the font grid needs to be rebuilt. This change just
makes that happen on all config reloads since it's a rare action so it's
not a performance concern.
2024-05-10 09:39:07 -07:00
cryptocode
a304c953bf Rename menu item variable name accordingly 2024-05-10 12:08:19 +02:00