Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-08-02 14:57:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

macos: only set titlebar color with enough luminance to avoid #1549

Browse Source
This commit is contained in:
Mitchell Hashimoto
2024-03-26 11:13:39 -07:00
parent 8f873dd488
commit f7129880f5
2 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
macos/Sources/Features/Terminal/TerminalController.swift
View File

@ -246,8 +246,12 @@ class TerminalController: NSWindowController, NSWindowDelegate,
// when cascading. // when cascading.
window.center() window.center()
// Set the background color of the window // Set the background color of the window. We only do this if the lum is
window.backgroundColor = NSColor(ghostty.config.backgroundColor) // over 0.1 to prevent: https://github.com/mitchellh/ghostty/issues/1549
let bgColor = NSColor(ghostty.config.backgroundColor)
if (bgColor.luminance > 0.1) {
window.backgroundColor = NSColor(ghostty.config.backgroundColor)
}
// This makes sure our titlebar renders correctly when there is a transparent background // This makes sure our titlebar renders correctly when there is a transparent background
window.titlebarOpacity = ghostty.config.backgroundOpacity window.titlebarOpacity = ghostty.config.backgroundOpacity

20
macos/Sources/Helpers/OSColor+Extension.swift
View File

@ -2,19 +2,29 @@ import Foundation
extension OSColor { extension OSColor {
var isLightColor: Bool { var isLightColor: Bool {
return self.luminance > 0.5
}
var luminance: Double {
var r: CGFloat = 0 var r: CGFloat = 0
var g: CGFloat = 0 var g: CGFloat = 0
var b: CGFloat = 0 var b: CGFloat = 0
var a: CGFloat = 0 var a: CGFloat = 0
self.getRed(&r, green: &g, blue: &b, alpha: &a) // getRed:green:blue:alpha requires sRGB space
let luminance = (0.299 * r) + (0.587 * g) + (0.114 * b) guard let rgb = self.usingColorSpace(.sRGB) else { return 0 }
return luminance > 0.5 rgb.getRed(&r, green: &g, blue: &b, alpha: &a)
return (0.299 * r) + (0.587 * g) + (0.114 * b)
} }
func darken(by amount: CGFloat) -> OSColor { func darken(by amount: CGFloat) -> OSColor {
var h: CGFloat = 0, s: CGFloat = 0, b: CGFloat = 0, a: CGFloat = 0 var h: CGFloat = 0, s: CGFloat = 0, b: CGFloat = 0, a: CGFloat = 0
self.getHue(&h, saturation: &s, brightness: &b, alpha: &a) self.getHue(&h, saturation: &s, brightness: &b, alpha: &a)
return OSColor(hue: h, saturation: s, brightness: min(b * (1 - amount), 1), alpha: a) return OSColor(
hue: h,
saturation: s,
brightness: min(b * (1 - amount), 1),
alpha: a
)
} }
} }