From f01930695a85770818f8c4710d0fe3191461873d Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Fri, 25 Nov 2022 15:30:03 -0800 Subject: [PATCH] metal: continue to render if single cell fails --- src/renderer/Metal.zig | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/renderer/Metal.zig b/src/renderer/Metal.zig index 0112b0926..9381d70c9 100644 --- a/src/renderer/Metal.zig +++ b/src/renderer/Metal.zig @@ -772,7 +772,7 @@ fn rebuildCells( var iter = self.font_shaper.runIterator(self.font_group, row); while (try iter.next(self.alloc)) |run| { for (try self.font_shaper.shape(run)) |shaper_cell| { - assert(try self.updateCell( + if (self.updateCell( term_selection, screen, row.getCell(shaper_cell.x), @@ -780,7 +780,15 @@ fn rebuildCells( run, shaper_cell.x, y, - )); + )) |update| { + assert(update); + } else |err| { + log.warn("error building cell, will be invalid x={} y={}, err={}", .{ + shaper_cell.x, + y, + err, + }); + } } }