From ec5dcf0850a1fa3a319cb10bee9cb526f4ad0add Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Wed, 23 Aug 2023 22:37:01 -0700 Subject: [PATCH] terminal/kitty-gfx: do not send response on transmit/display unless I --- src/terminal/kitty/graphics_exec.zig | 7 ++++++- src/termio/Exec.zig | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/terminal/kitty/graphics_exec.zig b/src/terminal/kitty/graphics_exec.zig index 5abe4abbb..fb6b835f7 100644 --- a/src/terminal/kitty/graphics_exec.zig +++ b/src/terminal/kitty/graphics_exec.zig @@ -146,6 +146,10 @@ fn transmit( // After the image is added, set the ID in case it changed result.id = load.image.id; + // If the original request had an image number, then we respond. + // Otherwise, we don't respond. + if (load.image.number == 0) return .{}; + return result; } @@ -228,7 +232,8 @@ fn display( }, } - return result; + // Display does not result in a response on success + return .{}; } /// Display a previously transmitted image. diff --git a/src/termio/Exec.zig b/src/termio/Exec.zig index 60c84eaac..91d95062a 100644 --- a/src/termio/Exec.zig +++ b/src/termio/Exec.zig @@ -1115,7 +1115,7 @@ const StreamHandler = struct { try resp.encode(buf_stream.writer()); const final = buf_stream.getWritten(); if (final.len > 2) { - //log.warn("kitty graphics response: {s}", .{final[1 .. final.len - 1]}); + // log.warn("kitty graphics response: {s}", .{std.fmt.fmtSliceHexLower(final)}); self.messageWriter(try termio.Message.writeReq(self.alloc, final)); } }