Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-15 08:16:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

input: kitty should not encode modifier-only key unless "report all"

Browse Source
This commit is contained in:
Mitchell Hashimoto
2023-08-24 21:24:41 -07:00
parent e0ee5d1763
commit e7c11f7d13
1 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/input/KeyEncoder.zig
View File

@ -123,6 +123,10 @@ fn kitty(
}
const entry = entry_ orelse return "";
// If this is just a modifier we require "report all" to send the sequence.
if (entry.modifier and !self.kitty_flags.report_all) return "";
const seq: KittySequence = seq: {
var seq: KittySequence = .{
.key = entry.code,
@ -802,7 +806,7 @@ test "kitty: composing with modifier" {
.mods = .{ .shift = true },
.composing = true,
},
.kitty_flags = .{ .disambiguate = true },
.kitty_flags = .{ .disambiguate = true, .report_all = true },
};
const actual = try enc.kitty(&buf);
@ -883,6 +887,38 @@ test "kitty: shift+tab" {
try testing.expectEqualStrings("\x1b[9;2u", actual);
}
test "kitty: left shift" {
var buf: [128]u8 = undefined;
var enc: KeyEncoder = .{
.event = .{
.key = .left_shift,
.mods = .{},
.utf8 = "",
},
.kitty_flags = .{ .disambiguate = true, .report_alternates = true },
};
const actual = try enc.kitty(&buf);
try testing.expectEqualStrings("", actual);
}
test "kitty: left shift with report all" {
var buf: [128]u8 = undefined;
var enc: KeyEncoder = .{
.event = .{
.key = .left_shift,
.mods = .{},
.utf8 = "",
},
.kitty_flags = .{ .disambiguate = true, .report_all = true },
};
const actual = try enc.kitty(&buf);
try testing.expectEqualStrings("\x1b[57441u", actual);
}
test "legacy: ctrl+alt+c" {
var buf: [128]u8 = undefined;
var enc: KeyEncoder = .{