Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 08:46:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

input: fix bs emitting sequence when it should not

Browse Source 
In korean input method on macos, it should simply return empty string.
Issue was created after https://github.com/mitchellh/ghostty/pull/1659.

```
gksr<BS> # 한ㄱ<BS>
```

'ㄱ' at the end should be removed with single <BS>, but for now
it requires two <bs> to remove 'ㄱ'.
This commit is contained in:
rok
2024-04-08 22:11:01 +09:00
parent 35c4059f18
commit df9b8f1fbc
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/input/KeyEncoder.zig
View File

@ -266,10 +266,8 @@ fn legacy(
if (self.event.utf8.len > 0) {
switch (self.event.key) {
else => {},
.enter,
.escape,
.backspace,
=> break :pc_style,
.backspace => return "",
.enter, .escape => break :pc_style,
}
}
@ -1658,7 +1656,7 @@ test "legacy: backspace with utf8 (dead key state)" {
};
const actual = try enc.legacy(&buf);
try testing.expectEqualStrings("A", actual);
try testing.expectEqualStrings("", actual);
}
test "legacy: enter with utf8 (dead key state)" {