From dbe6d6c29c16252c4867e5afcb83b13914bd9b03 Mon Sep 17 00:00:00 2001 From: cryptocode Date: Wed, 28 Aug 2024 17:48:22 +0200 Subject: [PATCH] Inspector: change color picker to use hex values The inspector currently show colors as decimal r,g,b values. With this change, the hex format is used instead. The motivation for this is that references to color typically use the hex format. One example is the palette definitions in a color scheme. Using the inspector/cell picker to help create and debug color themes should be more convenient after this change. If there's a usecase for the decimal format, we could add a config option or maybe a switch in the inspector UI. --- src/inspector/cell.zig | 12 ++++++++---- src/inspector/cursor.zig | 12 ++++++++---- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/src/inspector/cell.zig b/src/inspector/cell.zig index a3ad4ae73..9a3112bdd 100644 --- a/src/inspector/cell.zig +++ b/src/inspector/cell.zig @@ -140,7 +140,8 @@ pub const Cell = struct { _ = cimgui.c.igColorEdit3( "color_fg", &color, - cimgui.c.ImGuiColorEditFlags_NoPicker | + cimgui.c.ImGuiColorEditFlags_DisplayHex | + cimgui.c.ImGuiColorEditFlags_NoPicker | cimgui.c.ImGuiColorEditFlags_NoLabel, ); }, @@ -154,7 +155,8 @@ pub const Cell = struct { _ = cimgui.c.igColorEdit3( "color_fg", &color, - cimgui.c.ImGuiColorEditFlags_NoPicker | + cimgui.c.ImGuiColorEditFlags_DisplayHex | + cimgui.c.ImGuiColorEditFlags_NoPicker | cimgui.c.ImGuiColorEditFlags_NoLabel, ); }, @@ -177,7 +179,8 @@ pub const Cell = struct { _ = cimgui.c.igColorEdit3( "color_bg", &color, - cimgui.c.ImGuiColorEditFlags_NoPicker | + cimgui.c.ImGuiColorEditFlags_DisplayHex | + cimgui.c.ImGuiColorEditFlags_NoPicker | cimgui.c.ImGuiColorEditFlags_NoLabel, ); }, @@ -191,7 +194,8 @@ pub const Cell = struct { _ = cimgui.c.igColorEdit3( "color_bg", &color, - cimgui.c.ImGuiColorEditFlags_NoPicker | + cimgui.c.ImGuiColorEditFlags_DisplayHex | + cimgui.c.ImGuiColorEditFlags_NoPicker | cimgui.c.ImGuiColorEditFlags_NoLabel, ); }, diff --git a/src/inspector/cursor.zig b/src/inspector/cursor.zig index c2491b258..be1cd63fe 100644 --- a/src/inspector/cursor.zig +++ b/src/inspector/cursor.zig @@ -61,7 +61,8 @@ pub fn renderInTable( _ = cimgui.c.igColorEdit3( "color_fg", &color, - cimgui.c.ImGuiColorEditFlags_NoPicker | + cimgui.c.ImGuiColorEditFlags_DisplayHex | + cimgui.c.ImGuiColorEditFlags_NoPicker | cimgui.c.ImGuiColorEditFlags_NoLabel, ); }, @@ -75,7 +76,8 @@ pub fn renderInTable( _ = cimgui.c.igColorEdit3( "color_fg", &color, - cimgui.c.ImGuiColorEditFlags_NoPicker | + cimgui.c.ImGuiColorEditFlags_DisplayHex | + cimgui.c.ImGuiColorEditFlags_NoPicker | cimgui.c.ImGuiColorEditFlags_NoLabel, ); }, @@ -98,7 +100,8 @@ pub fn renderInTable( _ = cimgui.c.igColorEdit3( "color_bg", &color, - cimgui.c.ImGuiColorEditFlags_NoPicker | + cimgui.c.ImGuiColorEditFlags_DisplayHex | + cimgui.c.ImGuiColorEditFlags_NoPicker | cimgui.c.ImGuiColorEditFlags_NoLabel, ); }, @@ -112,7 +115,8 @@ pub fn renderInTable( _ = cimgui.c.igColorEdit3( "color_bg", &color, - cimgui.c.ImGuiColorEditFlags_NoPicker | + cimgui.c.ImGuiColorEditFlags_DisplayHex | + cimgui.c.ImGuiColorEditFlags_NoPicker | cimgui.c.ImGuiColorEditFlags_NoLabel, ); },