From dbe4530377cdf653ef3873bce14cac4bdbd18175 Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Mon, 23 Oct 2023 15:45:32 -0700 Subject: [PATCH] inspector: fix key memory leak --- src/inspector/Inspector.zig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/inspector/Inspector.zig b/src/inspector/Inspector.zig index 521590d90..0064c9958 100644 --- a/src/inspector/Inspector.zig +++ b/src/inspector/Inspector.zig @@ -131,7 +131,8 @@ pub fn recordKeyEvent(self: *Inspector, ev: inspector.key.Event) !void { try self.key_events.resize(self.surface.alloc, new_capacity); try self.key_events.append(ev); } else { - // TODO: there is a memory leak here, we have to deinit the oldest + var it = self.key_events.iterator(.forward); + if (it.next()) |old_ev| old_ev.deinit(self.surface.alloc); self.key_events.deleteOldest(1); try self.key_events.append(ev); },