Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-17 17:26:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

gtk: fix closing window when last tab is closed (#5837)

Browse Source 
Causes windows to not close and leave behind a "corpse" if they are not
the last window or we are running in single instance mode.

![image](https://github.com/user-attachments/assets/5f6860c2-7807-4ff1-9cad-d32dd4bc348b)
This commit is contained in:
Jeffrey C. Ollie
2025-02-17 11:37:51 -06:00
committed by GitHub
parent 16c6903706 3dbbbdee0b
commit da32534e8a
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/apprt/gtk/TabView.zig
View File

@ -193,6 +193,10 @@ pub fn addTab(self: *TabView, tab: *Tab, title: [:0]const u8) void {
} }
pub fn closeTab(self: *TabView, tab: *Tab) void { pub fn closeTab(self: *TabView, tab: *Tab) void {
// Save a pointer to the GTK window in case we need it later. It may be
// impossible to access later due to how resources are cleaned up.
const window: *gtk.Window = @ptrCast(@alignCast(self.window.window));
// closeTab always expects to close unconditionally so we mark this // closeTab always expects to close unconditionally so we mark this
// as true so that the close_page call below doesn't request // as true so that the close_page call below doesn't request
// confirmation. // confirmation.
@ -220,6 +224,8 @@ pub fn closeTab(self: *TabView, tab: *Tab) void {
const box: *gtk.Box = @ptrCast(@alignCast(tab.box)); const box: *gtk.Box = @ptrCast(@alignCast(tab.box));
box.as(gobject.Object).unref(); box.as(gobject.Object).unref();
} }
window.destroy();
} }
} }