From d85baa46315f5601a6b3e58dc8b18e0a2cd6ca98 Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Sat, 7 Oct 2023 14:26:11 -0700 Subject: [PATCH 1/2] terminal: alternate scroll (mode 1007) should not be enabled by default --- src/terminal/modes.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/terminal/modes.zig b/src/terminal/modes.zig index 983f2e451..1605e1fd6 100644 --- a/src/terminal/modes.zig +++ b/src/terminal/modes.zig @@ -165,7 +165,7 @@ const entries: []const ModeEntry = &.{ .{ .name = "focus_event", .value = 1004 }, .{ .name = "mouse_format_utf8", .value = 1005 }, .{ .name = "mouse_format_sgr", .value = 1006 }, - .{ .name = "mouse_alternate_scroll", .value = 1007, .default = true }, + .{ .name = "mouse_alternate_scroll", .value = 1007 }, .{ .name = "mouse_format_urxvt", .value = 1015 }, .{ .name = "mouse_format_sgr_pixels", .value = 1016 }, .{ .name = "alt_esc_prefix", .value = 1036, .default = true }, From f640fbc39499544208497bcf91b8fd17ec33dbc0 Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Sat, 7 Oct 2023 14:26:39 -0700 Subject: [PATCH 2/2] core: alternate scroll only sends up/down arrows, not left/right --- src/Surface.zig | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/Surface.zig b/src/Surface.zig index 2d448216e..e6cd409f3 100644 --- a/src/Surface.zig +++ b/src/Surface.zig @@ -1195,15 +1195,6 @@ pub fn scrollCallback( } } - if (x.delta_unsigned > 0) { - const seq = if (x.delta < 0) "\x1bOC" else "\x1bOD"; - for (0..x.delta_unsigned) |_| { - _ = self.io_thread.mailbox.push(.{ - .write_stable = seq, - }, .{ .forever = {} }); - } - } - // After sending all our messages we have to notify our IO thread try self.io_thread.wakeup.notify(); return;