From d7b37a9006784eb05779a499d4377a71d69446c8 Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Tue, 14 May 2024 07:19:15 -0400 Subject: [PATCH] config: default window-vsync to true Fixes #1409 Fixes macOS 14.4,14.5 kernel panics As noted in the comment in this diff, I've decided to default this to true because it fixes a couple _really bad_ issues for macOS users. For macOS users on 14.4 and 14.5 (latest released as of this commit), this resolves or at least heavily mitigates a possible kernel panic. This also fixes #1409 where external displays over certain connections such as DisplayLink would be unusably slow to render. --- src/config/Config.zig | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/config/Config.zig b/src/config/Config.zig index c565d538d..b783741b0 100644 --- a/src/config/Config.zig +++ b/src/config/Config.zig @@ -624,13 +624,15 @@ keybind: Keybinds = .{}, /// latency. If false, this will maximize redraw frequency but may cause tearing, /// and under heavy load may use more CPU and power. /// -/// This defaults to false because out of the box a lot of users prefer to -/// feel like the terminal is as responsive as possible. +/// This defaults to true because out-of-sync rendering on macOS can +/// cause kernel panics (macOS 14.4+) and performance issues for external +/// displays over some hardware such as DisplayLink. If you want to maximize +/// input latency, set this to false with the known aforementioned risks. /// /// Changing this value at runtime will only affect new terminals. /// /// This setting is only supported currently on macOS. -@"window-vsync": bool = false, +@"window-vsync": bool = true, /// If true, new windows and tabs will inherit the working directory of the /// previously focused window. If no window was previously focused, the default