Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-22 19:56:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(terminal/PageList): ensure enough pages before first page reuse

Browse Source 
Running alacritty/vtebench on some machines causes Ghostty to fail on
`assert(first != last)` when trying to grow scrollback. We now make sure
we have enough pages before trying to reuse pages.
This commit is contained in:
Khang Nguyen Duy
2024-09-21 21:46:25 +07:00
parent c6bbdfb7bf
commit d5ab772b66
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/terminal/PageList.zig
View File

@ -1694,7 +1694,7 @@ pub fn grow(self: *PageList) !?*List.Node {
// If allocation would exceed our max size, we prune the first page. // If allocation would exceed our max size, we prune the first page.
// We don't need to reallocate because we can simply reuse that first // We don't need to reallocate because we can simply reuse that first
// page. // page.
if (self.page_size + PagePool.item_size > self.maxSize()) prune: { if (self.pages.len > 1 and self.page_size + PagePool.item_size > self.maxSize()) prune: {
// If we need to add more memory to ensure our active area is // If we need to add more memory to ensure our active area is
// satisfied then we do not prune. // satisfied then we do not prune.
if (self.growRequiredForActive()) break :prune; if (self.growRequiredForActive()) break :prune;