Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-19 18:26:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

terminal: set PageList viewport to active area when cloned

Browse Source 
As an optimization, the renderer does not attempt to find the cell under
the cursor if the viewport is in the scrollback (i.e. not the active
area). When the renderer clones the screen state it also clones the
PageList, and the cloned PageList has its viewport set to the top of the
scrollback.

This caused the renderer to never attempt to find the cell under the
cursor, which in turn caused cells under the cursor to be improperly
highlighted. Instead, when the PageList is cloned initialize its
viewport to the active area.
This commit is contained in:
Gregory Anders
2024-03-18 15:07:56 -05:00
committed by Mitchell Hashimoto
parent 1f62284c26
commit d54d7cd581
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/terminal/PageList.zig
View File

@ -306,7 +306,7 @@ pub const Clone = struct {
/// Clone this pagelist from the top to bottom (inclusive).
///
/// The viewport is always moved to the top-left.
/// The viewport is always moved to the active area.
///
/// The cloned pagelist must contain at least enough rows for the active
/// area. If the region specified has less rows than the active area then
@ -478,7 +478,7 @@ pub fn clone(
.cols = self.cols,
.rows = self.rows,
.tracked_pins = tracked_pins,
.viewport = .{ .top = {} },
.viewport = .{ .active = {} },
.viewport_pin = viewport_pin,
};