Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 16:56:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1259 from rockorager/kitty-associated

Browse Source 
input: never report associated text on key release
This commit is contained in:
Mitchell Hashimoto
2024-01-08 08:13:30 -08:00
committed by GitHub
parent 39468757c6 baf8e04287
commit cfdf6cf312
1 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/input/KeyEncoder.zig
View File

@ -186,7 +186,7 @@ fn kitty(
} }
} }
if (self.kitty_flags.report_associated) associated: { if (self.kitty_flags.report_associated and seq.event != .release) associated: {
if (comptime builtin.target.isDarwin()) { if (comptime builtin.target.isDarwin()) {
// macOS has special logic because alt+key can produce unicode // macOS has special logic because alt+key can produce unicode
// characters. If we are treating option as alt, then we do NOT // characters. If we are treating option as alt, then we do NOT
@ -1364,6 +1364,29 @@ test "kitty: report associated" {
try testing.expectEqualStrings("\x1b[106:74;2;74u", actual); try testing.expectEqualStrings("\x1b[106:74;2;74u", actual);
} }
test "kitty: report associated on release" {
var buf: [128]u8 = undefined;
var enc: KeyEncoder = .{
.event = .{
.action = .release,
.key = .j,
.mods = .{ .shift = true },
.utf8 = "J",
.unshifted_codepoint = 106,
},
.kitty_flags = .{
.disambiguate = true,
.report_all = true,
.report_alternates = true,
.report_associated = true,
.report_events = true,
},
};
const actual = try enc.kitty(&buf);
try testing.expectEqualStrings("[106:74;2:3u", actual[1..]);
}
test "kitty: alternates omit control characters" { test "kitty: alternates omit control characters" {
var buf: [128]u8 = undefined; var buf: [128]u8 = undefined;
var enc: KeyEncoder = .{ var enc: KeyEncoder = .{