Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 15:56:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

apprt/gtk: when text is committed, end the preedit state (#5324)

Browse Source 
Fixes #3567

ibus 1.5.29 doesn't trigger a preedit end state when text is committed.
This is fixed in ibus 1.5.30, but we need to handle this case for older
versions which are shipped on LTS distributions such as Ubuntu.

Every other input method engine I've tried thus far also triggers a
preedit end state when text is committed, and none would expect preedit
to continue after text is committed. So I think it's safe to assume that
this is the expected behavior.
This commit is contained in:
Mitchell Hashimoto
2025-01-23 12:01:18 -08:00
committed by GitHub
parent eb21a58aa4 d1e45ef768
commit cd57612059
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/apprt/gtk/Surface.zig
View File

@ -1961,6 +1961,12 @@ fn gtkInputCommit(
// Committing ends composing state // Committing ends composing state
self.im_composing = false; self.im_composing = false;
// End our preedit state. Well-behaved input methods do this for us
// by triggering a preedit-end event but some do not (ibus 1.5.29).
self.core_surface.preeditCallback(null) catch |err| {
log.err("error in preedit callback err={}", .{err});
};
// Send the text to the core surface, associated with no key (an // Send the text to the core surface, associated with no key (an
// invalid key, which should produce no PTY encoding). // invalid key, which should produce no PTY encoding).
_ = self.core_surface.keyCallback(.{ _ = self.core_surface.keyCallback(.{