Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-08-02 14:57:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix the edge case when user tries to revert the title to default and hasn't set a title before

Browse Source
This commit is contained in:
Maciej Bartczak
2025-02-20 20:55:50 +01:00
committed by Jeffrey C. Ollie
parent 5e9908af27
commit cc9c45de2a
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/apprt/gtk/Surface.zig
View File

@ -960,8 +960,8 @@ pub fn setTitle(self: *Surface, slice: [:0]const u8, source: SetTitleSource) !vo
}; };
errdefer alloc.free(copy); errdefer alloc.free(copy);
// If The user has overriden the title we only want to update the terminal provided title // The user has overriden the title
// so that it can be restored to the most recent state // We only want to update the terminal provided title so that it can be restored to the most recent state.
if (self.title_from_terminal != null and source == .TERMINAL) { if (self.title_from_terminal != null and source == .TERMINAL) {
alloc.free(self.title_from_terminal.?); alloc.free(self.title_from_terminal.?);
self.title_from_terminal = copy; self.title_from_terminal = copy;
@ -2342,11 +2342,10 @@ fn gtkPromptTitleResponse(dialog: *c.GtkDialog, response: c.gint, ud: ?*anyopaqu
context.self.app.core_app.alloc.free(context.self.title_from_terminal.?); context.self.app.core_app.alloc.free(context.self.title_from_terminal.?);
context.self.title_from_terminal = null; context.self.title_from_terminal = null;
} }
} else { } else if (title.len > 0) {
// if this is the first time the user is setting the title, save the current terminal provided title // if this is the first time the user is setting the title, save the current terminal provided title
if (context.self.title_from_terminal == null and context.self.title_text != null) { if (context.self.title_from_terminal == null and context.self.title_text != null) {
const current_title = context.self.getTitle().?; context.self.title_from_terminal = context.self.app.core_app.alloc.dupeZ(u8, context.self.title_text.?) catch |err| switch (err) {
context.self.title_from_terminal = context.self.app.core_app.alloc.dupeZ(u8, current_title) catch |err| switch (err) {
error.OutOfMemory => { error.OutOfMemory => {
log.err("Failed to allocate memory for title: {}", .{err}); log.err("Failed to allocate memory for title: {}", .{err});
context.self.app.core_app.alloc.destroy(context); context.self.app.core_app.alloc.destroy(context);