From cbe04785724f14626ef9cfd2dadf94eb059385b9 Mon Sep 17 00:00:00 2001 From: eifr Date: Thu, 6 Feb 2025 10:19:23 +0200 Subject: [PATCH] remove config --- src/apprt/gtk/App.zig | 10 ++++++---- src/config/Config.zig | 13 ------------- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/src/apprt/gtk/App.zig b/src/apprt/gtk/App.zig index 4781b0ac3..e8bb98914 100644 --- a/src/apprt/gtk/App.zig +++ b/src/apprt/gtk/App.zig @@ -148,16 +148,18 @@ pub fn init(core_app: *CoreApp, opts: Options) !App { @"gles-api": bool = false, /// current gtk implementation for color management is not good enough. /// see: https://bugs.kde.org/show_bug.cgi?id=495647 - @"color-mgmt": bool, + @"color-mgmt": bool = true, /// Disabling Vulkan can improve startup times by hundreds of /// milliseconds on some systems. We don't use Vulkan so we can just /// disable it. vulkan: bool = false, - } = .{ - .@"color-mgmt" = config.@"gtk-gdk-disable-color-mgmt", - }; + } = .{}; environment: { + if (version.runtimeAtLeast(4, 17, 0)) { + gdk_disable.@"color-mgmt" = false; + } + if (version.runtimeAtLeast(4, 16, 0)) { // From gtk 4.16, GDK_DEBUG is split into GDK_DEBUG and GDK_DISABLE. // For the remainder of "why" see the 4.14 comment below. diff --git a/src/config/Config.zig b/src/config/Config.zig index 6d09fc9ce..3010b87d1 100644 --- a/src/config/Config.zig +++ b/src/config/Config.zig @@ -1350,19 +1350,6 @@ keybind: Keybinds = .{}, /// Specified as either hex (`#RRGGBB` or `RRGGBB`) or a named X11 color. @"window-titlebar-foreground": ?Color = null, -/// Controls whether to disable GDK color management in GTK applications. -/// -/// By default this is set to `false`, meaning color management is enabled. -/// You may want to enable this setting (set to `true`) if you experience: -/// - Incorrect or washed out colors in your terminal -/// - Color inconsistencies between GTK applications -/// - Performance issues related to color management -/// -/// This is a workaround for known issues with GTK's color management implementation, -/// particularly affecting applications running under Wayland. -/// See: https://bugs.kde.org/show_bug.cgi?id=495647 -@"gtk-gdk-disable-color-mgmt": bool = false, - /// This controls when resize overlays are shown. Resize overlays are a /// transient popup that shows the size of the terminal while the surfaces are /// being resized. The possible options are: