From ca844ca3c064cfdd51a9c29a20dcbfe314c0d712 Mon Sep 17 00:00:00 2001
From: "Jeffrey C. Ollie" <jeff@ocjtech.us>
Date: Sat, 2 Nov 2024 23:30:21 -0500
Subject: [PATCH] core: list valid options if an invalid value is detected
 parsing an enum

---
 src/cli/args.zig | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/src/cli/args.zig b/src/cli/args.zig
index bfd40c633..9a8d1ae42 100644
--- a/src/cli/args.zig
+++ b/src/cli/args.zig
@@ -133,7 +133,29 @@ pub fn parse(
                 error.OutOfMemory => return err,
                 error.InvalidField => "unknown field",
                 error.ValueRequired => "value required",
-                error.InvalidValue => "invalid value",
+                error.InvalidValue => msg: {
+                    var buf = std.ArrayList(u8).init(arena_alloc);
+                    errdefer buf.deinit();
+                    const writer = buf.writer();
+                    try writer.print("invalid value \"{?s}\"", .{value});
+                    const typeinfo = @typeInfo(T);
+                    inline for (typeinfo.Struct.fields) |f| {
+                        if (std.mem.eql(u8, key, f.name)) {
+                            switch (@typeInfo(f.type)) {
+                                .Enum => |e| {
+                                    try writer.print(", valid values are: ", .{});
+                                    inline for (e.fields, 0..) |field, i| {
+                                        if (i != 0) try writer.print(", ", .{});
+                                        try writer.print("{s}", .{field.name});
+                                    }
+                                },
+                                else => {},
+                            }
+                            break;
+                        }
+                    }
+                    break :msg try buf.toOwnedSliceSentinel(0);
+                },
                 else => try std.fmt.allocPrintZ(
                     arena_alloc,
                     "unknown error {}",